-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the code to comply with our desired pylint
configuration
#523
Comments
A complete list of
|
How do people feel about raising the "too-many-arguments" threshold from 5 to a larger number? I find 5 a bit tedious to comply with everywhere. For example, all the top-level interface functions in probnum seem to have more than 5. Many of the lower-level methods also depend on a number of parameters. Usually, most of them are optional anyway. It also feels like defeating the purpose to put "pylint: disable="too-many-arguments" everywhere. |
And, on a similar note, how about disabling "missing-function-docstring" for the tests? Most tests are one-liner-functions with (usually) a rather descriptive name. How much value does a (forced) docstring add there? |
@pnkraemer I quoted these comments in #470. Let's discuss there :) |
Is your feature request related to a problem? Please describe.
For legacy reasons, we disable subsets of
pylint
messages on a per-package basis (seetox.ini
), since our code does not yet fully comply with the desiredpylint
configuration (seepyproject.toml
).Moreover, a bug in our CI configuration destroyed previous efforts to become
pylint
compliant, since non-compliant code could be merged without CI failure.This bug is fixed by #522.
Describe the solution you'd like.
The code should be refactored such that we can re-enable the messages disabled on a per-module basis for good. Due to our CI configuration, this can be done independently by the individual package maintainers. We can use this issue to track our progress.
Compliant packages:
The text was updated successfully, but these errors were encountered: