Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylint should be run on the whole package #197

Closed
marvinpfoertner opened this issue Aug 30, 2020 · 3 comments
Closed

pylint should be run on the whole package #197

marvinpfoertner opened this issue Aug 30, 2020 · 3 comments
Labels
improvement Improvements of existing functionality testing and CI Unit tests, coverage and continuous integration

Comments

@marvinpfoertner
Copy link
Collaborator

Currently, pylint is only run on individual subpackages of probnum.
Unfortunately, things like cyclic imports between these packages can't be found unless pylint is run on the whole package.
We should run pylint on the entire package using a reduced set of messages to catch more errors.

FYI @nathanaelbosch

@marvinpfoertner marvinpfoertner added improvement Improvements of existing functionality testing and CI Unit tests, coverage and continuous integration labels Aug 30, 2020
@nathanaelbosch
Copy link
Collaborator

Since we keep the full pylint config up-to-date in the ./pyproject.toml it should be sufficient to just perform an additional pylint src run as a part of our CI, is that right? Or do you suggest running it with different settings?

@marvinpfoertner
Copy link
Collaborator Author

Since we keep the full pylint config up-to-date in the ./pyproject.toml it should be sufficient to just perform an additional pylint src run as a part of our CI, is that right? Or do you suggest running it with different settings?

I agree, I think out pyproject.toml settings should suffice

@marvinpfoertner
Copy link
Collaborator Author

Superseded by #523.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements of existing functionality testing and CI Unit tests, coverage and continuous integration
Projects
None yet
Development

No branches or pull requests

2 participants