Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor probnum.randvars to resolve the pylint messages #159

Closed
10 of 11 tasks
nathanaelbosch opened this issue Aug 19, 2020 · 2 comments
Closed
10 of 11 tasks

Refactor probnum.randvars to resolve the pylint messages #159

nathanaelbosch opened this issue Aug 19, 2020 · 2 comments
Assignees
Labels
randvars Issues related to random variables refactoring Refactoring of existing functionality

Comments

@nathanaelbosch
Copy link
Collaborator

nathanaelbosch commented Aug 19, 2020

At the time of writing, probnum.randvars triggers the following pylint messages:

  • too-many-instance-attributes
  • broad-except
  • arguments-differ
  • abstract-method
  • too-many-arguments
  • protected-access
  • duplicate-code
  • unused-argument
  • missing-module-docstring
  • missing-function-docstring
  • raise-missing-from

Goal:
Our long-term goal is to enable all of these checks for all parts of the project. Therefore, we should continuously work on fixing these. Currently, pylint is set up to have different checks for different modules, such that we can work on these problems individually and progress more quickly :)

To work on this issue you can check for these messages individually by calling:

pylint src/probnum/prob --disable=all --enable=<message>

Then, after fixing all errors/warnings, you should remove the exception from the corresponding line in ./tox.ini, such that this message will be tracked in the future.

@nathanaelbosch nathanaelbosch added refactoring Refactoring of existing functionality randvars Issues related to random variables labels Aug 19, 2020
@marvinpfoertner marvinpfoertner self-assigned this Aug 20, 2020
@marvinpfoertner marvinpfoertner changed the title Refactor probnum.prob to resolve the pylint messages Refactor probnum.random_variables to resolve the pylint messages Aug 29, 2020
@marvinpfoertner
Copy link
Collaborator

Most of these points will be resolved by #164.

@JonathanWenger JonathanWenger changed the title Refactor probnum.random_variables to resolve the pylint messages Refactor probnum.randvars to resolve the pylint messages May 8, 2021
@marvinpfoertner
Copy link
Collaborator

Superseded by #523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
randvars Issues related to random variables refactoring Refactoring of existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants