Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests to resolve the pylint messages #160

Closed
nathanaelbosch opened this issue Aug 19, 2020 · 2 comments
Closed

Refactor tests to resolve the pylint messages #160

nathanaelbosch opened this issue Aug 19, 2020 · 2 comments
Labels
refactoring Refactoring of existing functionality

Comments

@nathanaelbosch
Copy link
Collaborator

nathanaelbosch commented Aug 19, 2020

At the time of writing, tests triggers the following pylint messages:

  • line-too-long
  • duplicate-code
  • missing-class-docstring
  • unnecessary-pass
  • unused-variable
  • protected-access
  • attribute-defined-outside-init
  • no-self-use
  • abstract-class-instantiated
  • too-many-arguments
  • too-many-instance-attributes
  • too-many-locals
  • unused-argument
  • fixme
  • missing-module-docstring
  • missing-function-docstring

It might also be that we do not actually want to fix all of these for the tests, so if you have an opinion on this please share it by commenting on this issue.

Goal:
Our long-term goal is to enable all of these checks for all parts of the project. Therefore, we should continuously work on fixing these. Currently, pylint is set up to have different checks for different modules, such that we can work on these problems individually and progress more quickly :)

To work on this issue you can check for these messages individually by calling:

pylint tests --disable=all --enable=<message>

Then, after fixing all errors/warnings, you should remove the exception from the corresponding line in ./tox.ini, such that this message will be tracked in the future.

@pnkraemer
Copy link
Collaborator

I conjecture that refactoring the tests so that pylint is happy will be painful... I suggest to tackle this last ;)

@marvinpfoertner
Copy link
Collaborator

Superseded by #523.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring of existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants