Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy-to-fix pylint issues in probnum.diffeq #669

Closed
3 tasks
pnkraemer opened this issue Mar 23, 2022 · 1 comment · Fixed by #694
Closed
3 tasks

Easy-to-fix pylint issues in probnum.diffeq #669

pnkraemer opened this issue Mar 23, 2022 · 1 comment · Fixed by #694
Labels
diffeq Issues related to differential equations good first issue Good for newcomers

Comments

@pnkraemer
Copy link
Collaborator

Context:
There is ongoing work on refactoring probnum to comply with the desired pylint configuration. See #523 for context.
Many of those refactorings should be very simple to resolve.

Details:
For the probnum.diffeq subpackage, these are

  • line-too-long (some docstrings have too long lines)
  • no-else-return
  • no-else-raise

Once a message has been resolved, please remove the explicit pylint-ignore on the bottom of the tox.ini file.

Some notes, if you would like to take this on:

  • Have a look at the contribution guide before opening a pull request.
  • Please strongly consider resolving each message in a separate pull request. This makes the reviews go more smoothly.
@pnkraemer pnkraemer added good first issue Good for newcomers diffeq Issues related to differential equations labels Mar 23, 2022
@akapoor13
Copy link
Contributor

Working on this today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diffeq Issues related to differential equations good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants