Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(goal_planner): remove enable_safety_check because it is default #10052

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Jan 30, 2025

Description

goal_planner never works without PredictedObject, so enable_safety_check is treated as true.

depends #10050

Related links

Parent Issue:

  • Link

How was this PR tested?

Psim works

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jan 30, 2025
Copy link

github-actions bot commented Jan 30, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@soblin soblin force-pushed the refactor/goal-planner/remove-enable-safety-check branch 8 times, most recently from 8dcce5d to 4869384 Compare January 31, 2025 03:03
@soblin soblin force-pushed the refactor/goal-planner/remove-enable-safety-check branch from 8e9e526 to cd59bbb Compare January 31, 2025 03:16
@soblin soblin changed the title refactor(goal_planner): remove enable_safety_check because it is default refactor(goal_planner): remove enable_safety_check because it is default Jan 31, 2025
@soblin soblin marked this pull request as ready for review January 31, 2025 03:16
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 31, 2025
@soblin soblin enabled auto-merge (squash) January 31, 2025 03:16
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 28.31%. Comparing base (d63bec2) to head (cd59bbb).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...or_path_goal_planner_module/src/decision_state.cpp 0.00% 9 Missing ⚠️
..._behavior_path_goal_planner_module/src/manager.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10052      +/-   ##
==========================================
- Coverage   28.32%   28.31%   -0.01%     
==========================================
  Files        1485     1488       +3     
  Lines      111103   111142      +39     
  Branches    43171    43158      -13     
==========================================
  Hits        31468    31468              
- Misses      76614    76652      +38     
- Partials     3021     3022       +1     
Flag Coverage Δ *Carryforward flag
differential 0.50% <0.00%> (?)
total 28.34% <ø> (+0.02%) ⬆️ Carriedforward from d63bec2

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 46ec581 into autowarefoundation:main Jan 31, 2025
45 of 50 checks passed
@soblin soblin deleted the refactor/goal-planner/remove-enable-safety-check branch January 31, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants