refactor(goal_planner): remove enable_safety_check because it is default #10052
+16
−26
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Jan 31, 2025 in 47s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Change in average Code Health of affected files: +0.01 (4.60 -> 4.61)
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 4 findings(s) ✅
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method manager.cpp: GoalPlannerModuleManager::initGoalPlannerParameters
✅ Improving Code Health:
- Large Method manager.cpp: GoalPlannerModuleManager::updateModuleParams
- Large Method manager.cpp: GoalPlannerModuleManager::initGoalPlannerParameters
- Complex Method decision_state.cpp: PathDecisionStateController::get_next_state
- Complex Conditional decision_state.cpp: PathDecisionStateController::get_next_state
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Complex Method
PathDecisionStateController::get_next_state decreases in cyclomatic complexity from 18 to 15, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Conditional
PathDecisionStateController::get_next_state no longer has a complex conditional
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
GoalPlannerModuleManager::initGoalPlannerParameters has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Large Method
GoalPlannerModuleManager::updateModuleParams decreases from 353 to 350 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Large Method
GoalPlannerModuleManager::initGoalPlannerParameters is no longer above the threshold for lines of code. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Loading