hal: renesas: Replace the BSP clock settings with new macros. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soburi
force-pushed
the
clock_rework
branch
5 times, most recently
from
6a74d76 to
33ff5b7
Compare
soburi
changed the title
soburi
force-pushed
the
clock_rework
branch
from
33ff5b7 to
4c68922
Compare
soburi
force-pushed
the
clock_rework
branch
from
4c68922 to
6986e6e
Compare
|
Could you take a look? |
duynguyenxa
reviewed
Sep 24, 2024
| #define BSP_CFG_I3CCLK_DIV BSP_CLOCK_PROP_HAS_STATUS_OKAY_OR(DT_NODELABEL(i3cclk), clk_div, 0) | ||
| #define BSP_CFG_UCK_SOURCE RA_CGC_CLK_SRC(DT_CLOCKS_CTLR(DT_NODELABEL(uclk))) | ||
| #define BSP_CFG_UCK_DIV RA_CGC_CLK_DIV(DT_NODELABEL(uclk), div, 1) | ||
| #define BSP_CFG_U60CK_SOURCE RA_CGC_CLK_SRC(DT_CLOCKS_CTLR(DT_NODELABEL(u64clk))) |
There was a problem hiding this comment.
@soburi , This seem to be a mistake
Suggested change
| #define BSP_CFG_U60CK_SOURCE RA_CGC_CLK_SRC(DT_CLOCKS_CTLR(DT_NODELABEL(u64clk))) | |
| #define BSP_CFG_U60CK_SOURCE RA_CGC_CLK_SRC(DT_CLOCKS_CTLR(DT_NODELABEL(u60clk))) |
There was a problem hiding this comment.
Thank you for catching.
I fixed it.
And found some mistakes in ra6m1, ra8d1 and ra8t1, also fixed.
| #define BSP_CFG_LCDCLK_DIV BSP_CLOCK_PROP_HAS_STATUS_OKAY_OR(DT_NODELABEL(lcdclk), clk_div, 0) | ||
| #define BSP_CFG_UCK_SOURCE RA_CGC_CLK_SRC(DT_CLOCKS_CTLR(DT_NODELABEL(uclk))) | ||
| #define BSP_CFG_UCK_DIV RA_CGC_CLK_DIV(DT_NODELABEL(uclk), div, 1) | ||
| #define BSP_CFG_U60CK_SOURCE RA_CGC_CLK_SRC(DT_CLOCKS_CTLR(DT_NODELABEL(u64clk))) |
| #define BSP_CFG_LCDCLK_DIV BSP_CLOCK_PROP_HAS_STATUS_OKAY_OR(DT_NODELABEL(lcdclk), clk_div, 0) | ||
| #define BSP_CFG_UCK_SOURCE RA_CGC_CLK_SRC(DT_CLOCKS_CTLR(DT_NODELABEL(uclk))) | ||
| #define BSP_CFG_UCK_DIV RA_CGC_CLK_DIV(DT_NODELABEL(uclk), div, 1) | ||
| #define BSP_CFG_U60CK_SOURCE RA_CGC_CLK_SRC(DT_CLOCKS_CTLR(DT_NODELABEL(u64clk))) |
soburi
force-pushed
the
clock_rework
branch
from
6986e6e to
c1d40bd
Compare
BSP_CFG_ADCCLK_DIV, BSP_CFG_ADCCLK_SOURCE, BSP_CFG_SDADCCLK_DIV and BSP_CFG_SDADCCLK_SOURCE are not referenced. Removed these. BSP_CLOCK_PROP_HAS_STATUS_OKAY_OR was renamed and moved into `include/zephyr/drivers/clock_control` Signed-off-by: TOKITA Hiroshi <[email protected]>
Replace the includeed header file from `zephyr/dt-bindings/clock/ra_clock.h` to `zephyr/drivers/clock_control/renesas_ra_cgc.h` to standardize the macros. Signed-off-by: TOKITA Hiroshi <[email protected]>
To simplify the DeviceTree notation, we have introduced macros that derive BSP macro definitions from DeviceTree values. The clock settings were rewritten by it. Signed-off-by: TOKITA Hiroshi <[email protected]>
soburi
force-pushed
the
clock_rework
branch
from
c1d40bd to
7205e63
Compare
duynguyenxa
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
LGTM
@thaoluonguw , please take a look for this PR, related PR in Zephyr zephyrproject-rtos/zephyr#78365
|
@thaoluonguw |
thaoluonguw
approved these changes
Oct 1, 2024
|
@KhiemNguyenT |
KhiemNguyenT
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To simplify the DeviceTree notation, we have introduced macros
that derive BSP macro definitions from DeviceTree values.
The clock settings were rewritten by it.