Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more debug information for sync #WPB-11603 #3523

Merged
merged 8 commits into from
Oct 25, 2024

Conversation

damian-kaczmarek
Copy link
Contributor

@damian-kaczmarek damian-kaczmarek commented Oct 17, 2024

BugWPB-11603 [Android] App stuck on "decrypting messages"

What's new in this PR?

Issues

Wasn't able to reproduce the problem. Added some more debug information. Possibly we should improve the UI to inform user about networking problems. Or listen for our requests failing not being respond for a long time.

Dependencies (Optional)

More related changes in android: wireapp/kalium#3066


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@damian-kaczmarek damian-kaczmarek self-assigned this Oct 17, 2024
@echoes-hq echoes-hq bot added the echoes: bugs Technical or functional defects in the product label Oct 17, 2024
@damian-kaczmarek damian-kaczmarek changed the base branch from develop to release/candidate October 17, 2024 13:47
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 45.22%. Comparing base (499302d) to head (580d08a).
Report is 2 commits behind head on release/candidate.

Files with missing lines Patch % Lines
...tlin/com/wire/android/util/CurrentScreenManager.kt 20.00% 8 Missing ⚠️
...rc/main/kotlin/com/wire/android/WireApplication.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3523      +/-   ##
=====================================================
- Coverage              45.24%   45.22%   -0.03%     
=====================================================
  Files                    470      470              
  Lines                  15708    15716       +8     
  Branches                2627     2627              
=====================================================
  Hits                    7107     7107              
- Misses                  7856     7864       +8     
  Partials                 745      745              
Files with missing lines Coverage Δ
...rc/main/kotlin/com/wire/android/WireApplication.kt 0.00% <0.00%> (ø)
...tlin/com/wire/android/util/CurrentScreenManager.kt 32.46% <20.00%> (-3.77%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 499302d...580d08a. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3523.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3523.apk is available for download

Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

import javax.inject.Singleton

@Singleton
class LifecycleLogger @Inject constructor() : DefaultLifecycleObserver {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have CurrentScreenManager that also listen to lifecycle changes. I'd suggest to make those logs there as well to avoid duplication

Copy link
Contributor

Built wire-android-staging-compat-pr-3523.apk is available for download

…into chore/debug-information-sync

# Conflicts:
#	kalium
Copy link
Contributor

@damian-kaczmarek looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (release/candidate) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

release/candidate This PR
96044bc0e47427e263e0348099a17399392b42ea 1531aa60468a47cd045cb74213e145457e8810d6

Is this intentional?

@damian-kaczmarek damian-kaczmarek added this pull request to the merge queue Oct 25, 2024
@damian-kaczmarek damian-kaczmarek removed this pull request from the merge queue due to a manual request Oct 25, 2024
Copy link

sonarcloud bot commented Oct 25, 2024

@damian-kaczmarek damian-kaczmarek added this pull request to the merge queue Oct 25, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3523.apk is available for download

Merged via the queue into release/candidate with commit 504f25e Oct 25, 2024
12 of 13 checks passed
@damian-kaczmarek damian-kaczmarek deleted the chore/debug-information-sync branch October 25, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: bugs Technical or functional defects in the product size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants