-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add more debug information for sync #WPB-11603 #3523
chore: add more debug information for sync #WPB-11603 #3523
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3523 +/- ##
=====================================================
- Coverage 45.24% 45.22% -0.03%
=====================================================
Files 470 470
Lines 15708 15716 +8
Branches 2627 2627
=====================================================
Hits 7107 7107
- Misses 7856 7864 +8
Partials 745 745
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3523.apk is available for download |
Built wire-android-dev-debug-pr-3523.apk is available for download |
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
2cb0d18
to
de076b4
Compare
aa2b152
to
77f0d21
Compare
77f0d21
to
c881cc7
Compare
import javax.inject.Singleton | ||
|
||
@Singleton | ||
class LifecycleLogger @Inject constructor() : DefaultLifecycleObserver { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have CurrentScreenManager
that also listen to lifecycle changes. I'd suggest to make those logs there as well to avoid duplication
Built wire-android-staging-compat-pr-3523.apk is available for download |
…into chore/debug-information-sync # Conflicts: # kalium
@damian-kaczmarek looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (release/candidate) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
…into chore/debug-information-sync
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3523.apk is available for download |
What's new in this PR?
Issues
Wasn't able to reproduce the problem. Added some more debug information. Possibly we should improve the UI to inform user about networking problems. Or listen for our requests failing not being respond for a long time.
Dependencies (Optional)
More related changes in android: wireapp/kalium#3066
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.