Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more debug information for sync #WPB-11603 🍒 #3558

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

github-actions[bot]
Copy link
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-11603 [Android] App stuck on "decrypting messages"

What's new in this PR?

Issues

Wasn't able to reproduce the problem. Added some more debug information. Possibly we should improve the UI to inform user about networking problems. Or listen for our requests failing not being respond for a long time.

Dependencies (Optional)

More related changes in android: wireapp/kalium#3066


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch echoes: bugs Technical or functional defects in the product size/XS labels Oct 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 45.19%. Comparing base (7079f85) to head (e659c42).

Files with missing lines Patch % Lines
...tlin/com/wire/android/util/CurrentScreenManager.kt 20.00% 8 Missing ⚠️
...rc/main/kotlin/com/wire/android/WireApplication.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3558      +/-   ##
===========================================
- Coverage    45.21%   45.19%   -0.03%     
===========================================
  Files          471      471              
  Lines        15732    15740       +8     
  Branches      2630     2630              
===========================================
  Hits          7114     7114              
- Misses        7870     7878       +8     
  Partials       748      748              
Files with missing lines Coverage Δ
...rc/main/kotlin/com/wire/android/WireApplication.kt 0.00% <0.00%> (ø)
...tlin/com/wire/android/util/CurrentScreenManager.kt 32.46% <20.00%> (-3.77%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7079f85...e659c42. Read the comment docs.

Copy link
Contributor Author

Built wire-android-staging-compat-pr-3558.apk is available for download

Copy link
Contributor Author

Built wire-android-dev-debug-pr-3558.apk is available for download

Copy link

sonarcloud bot commented Oct 29, 2024

@damian-kaczmarek damian-kaczmarek added this pull request to the merge queue Oct 29, 2024
Copy link
Contributor Author

Built wire-android-staging-compat-pr-3558.apk is available for download

Copy link
Contributor Author

Built wire-android-dev-debug-pr-3558.apk is available for download

Merged via the queue into develop with commit d9b6b91 Oct 29, 2024
12 of 13 checks passed
@damian-kaczmarek damian-kaczmarek deleted the chore/debug-information-sync-cherry-pick branch October 29, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes: bugs Technical or functional defects in the product size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants