chore: add more debug information for sync #WPB-11603 #3066
Conversation
echoes-hq
bot
added
the
echoes: bugs
|
Bencher Report| Branch | chore/debug-information-sync |
| Testbed | ubuntu-latest |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 685,433.22 |
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 339,366,256.71 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 933,078,480.48 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 21,758,285.49 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3066 +/- ##
==================================================
Coverage 52.70% 52.70%
==================================================
Files 1317 1317
Lines 51108 51108
Branches 4742 4742
==================================================
Hits 26937 26937
+ Misses 22246 22245 -1
- Partials 1925 1926 +1
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3144 Passed, 106 Skipped, 34.82s Total Time |
| "validated:${networkCapabilities.hasCapability(NetworkCapabilities.NET_CAPABILITY_VALIDATED)}" | ||
| ) | ||
| defaultNetworkDataStateFlow.update { DefaultNetworkData.Connected(network, networkCapabilities) } | ||
| val loggerMessage = buildString { |
There was a problem hiding this comment.
Suggestion: We can try to log in json format, so we can later parse it and do some filtering in Datadog
You can take a look at this utility:
There was a problem hiding this comment.
thanks, added. Good to know we have such method
|
damian-kaczmarek
requested review from
Garzas,
a team,
vitorhugods,
mchenani and
ohassine
and removed request for
a team
What's new in this PR?
Issues
Wasn't able to reproduce the problem. Added some more debug information. Possibly we should improve the UI to inform user about networking problems. Or listen for our requests failing not being respond for a long time.
Dependencies (Optional)
more related changes in kalium: wireapp/wire-android#3523
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.