fix: swipe to reply activated too early #3034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitorhugods
requested review from
saleniuk,
a team,
typfel,
yamilmedina,
mchenani and
ohassine
and removed request for
a team
Test Results928 tests 928 ✅ 11m 54s ⏱️ Results for commit 82be5b3. ♻️ This comment has been updated with latest results. |
|
Build 4980 failed. |
vitorhugods
force-pushed
the
fix/swipe-to-reply-activated-too-early
branch
from
c749c9b
to
82be5b3
Compare
borichellow
approved these changes
May 24, 2024
saleniuk
approved these changes
May 24, 2024
yamilmedina
approved these changes
May 24, 2024
|
4 tasks
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 4985 succeeded. The build produced the following APK's: |
6 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
Swipe to reply is being activated INSTANTLY, as soon as the gesture starts.
Causes
We upgraded to an alpha05 version of the compose foundation.
Solutions
The issue was fixed on alpha08. I upgraded to beta01 (one release after the fix, but more stable).
The lib also had a few breaking changes I had to address:
TextFieldCharSequencewas made internal, andselectionwas taken out of it, exposed inTextFieldStateBasicTextFielddoesn't takekeyboardActionsanymore, but rather aKeyboardActionHandler, and it can be removed to keep the default bahaviour. I couldn't find usages for this in our codebase, so I just removed the parameter.Testing
Manually tested.
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.