fix: swipe to reply activated too early 🍒 #3036
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
Swipe to reply is being activated INSTANTLY, as soon as the gesture starts.
Causes
We upgraded to an alpha05 version of the compose foundation.
Solutions
The issue was fixed on alpha08. I upgraded to beta01 (one release after the fix, but more stable).
The lib also had a few breaking changes I had to address:
TextFieldCharSequence
was made internal, andselection
was taken out of it, exposed inTextFieldState
BasicTextField
doesn't takekeyboardActions
anymore, but rather aKeyboardActionHandler
, and it can be removed to keep the default bahaviour. I couldn't find usages for this in our codebase, so I just removed the parameter.Testing
Manually tested.
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.