Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swipe to reply activated too early 🍒 #3036

Conversation

github-actions[bot]
Copy link
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Swipe to reply is being activated INSTANTLY, as soon as the gesture starts.

Causes

We upgraded to an alpha05 version of the compose foundation.

Solutions

The issue was fixed on alpha08. I upgraded to beta01 (one release after the fix, but more stable).
The lib also had a few breaking changes I had to address:

  • TextFieldCharSequence was made internal, and selection was taken out of it, exposed in TextFieldState
  • BasicTextField doesn't take keyboardActions anymore, but rather a KeyboardActionHandler, and it can be removed to keep the default bahaviour. I couldn't find usages for this in our codebase, so I just removed the parameter.

Testing

Manually tested.


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch size/XS labels May 24, 2024
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vitorhugods
Copy link
Member

Closed, as develop is already using Foundation beta01

@AndroidBob
Copy link
Collaborator

Build 4987 failed.

@yamilmedina yamilmedina deleted the fix/swipe-to-reply-activated-too-early-cherry-pick branch July 30, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants