Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send button disabled after writing message [WPB-9421] #3039

Merged

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented May 27, 2024

BugWPB-9421 [Android] Send button not working


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Send button is disabled after writing a message.

Causes (Optional)

This PR #3034 updated libs for RC and changed the StateSyncingModifier to work with new library version, however, using TextFieldState inside observeReads does not emit values when the text inside it changes.

Solutions

Use the solution proposed by Google in the sample: https://android.googlesource.com/platform/frameworks/support/+/refs/heads/androidx-main/compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/BasicTextFieldValueSample.kt
which is to copy values to TextFieldValue in observeReads instead.

Testing

How to Test

Open conversation screen, type something and try to send a message.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@saleniuk saleniuk requested review from a team, typfel, yamilmedina, alexandreferris, mchenani and ohassine and removed request for a team May 27, 2024 10:56
Copy link
Contributor

Test Results

928 tests   928 ✅  12m 23s ⏱️
123 suites    0 💤
123 files      0 ❌

Results for commit cd60778.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4997 succeeded.

The build produced the following APK's:

@saleniuk saleniuk enabled auto-merge (squash) May 27, 2024 11:59
Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@saleniuk saleniuk merged commit 8f7d942 into release/candidate May 27, 2024
12 of 13 checks passed
@saleniuk saleniuk deleted the fix/send-button-disabled-after-writing-message branch May 27, 2024 12:22
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4999 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants