Add VolumeInfo metadata structures. #7070

blackpiglet · 2023-11-07T12:04:29Z

Modify design according to comments.
Add PVInfo structure.

Thank you for contributing to Velero!

Please add a summary of your change

Add the VolumeInfo metadata structures for issues pv-backup-info

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

Accepted the DCO. Commits without the DCO will delay acceptance.
Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
Updated the corresponding documentation in site/content/docs/main.

blackpiglet · 2023-11-07T12:15:00Z

@draghuram
Please take a look at the PR. I modified the design document according to comments in #6962.

blackpiglet · 2023-11-07T12:16:20Z

@allenxu404
Please also take a look. I added the PVInfo into the VolumeInfo structure.

codecov · 2023-11-07T12:25:28Z

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (cb5ffe2) 61.16% compared to head (b440a4f) 61.19%.
Report is 27 commits behind head on main.

Files	Patch %	Lines
pkg/persistence/object_store.go	64.70%	4 Missing and 2 partials ⚠️
pkg/controller/backup_controller.go	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7070      +/-   ##
==========================================
+ Coverage   61.16%   61.19%   +0.02%     
==========================================
  Files         256      258       +2     
  Lines       27222    27353     +131     
==========================================
+ Hits        16650    16738      +88     
- Misses       9389     9430      +41     
- Partials     1183     1185       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

draghuram

Design changes look good to me though I have few minor comments.

design/pv_backup_info.md

pkg/volume/volume_info_common.go

pkg/volume/volume_info_v1.go

design/pv_backup_info.md

pkg/volume/volume_info_common.go

pkg/volume/volume_info_v1.go

pkg/volume/volume_info_common.go

design/pv_backup_info.md

pkg/volume/volume_info_v1.go

pkg/volume/volume_info_common.go

Modify design according to comments. Add PVInfo structure. Add backup VolumeInfo's object storage's put and get methods. Signed-off-by: Xun Jiang <[email protected]>

github-actions bot added Area/Design Design Documents has-unit-tests labels Nov 7, 2023

blackpiglet force-pushed the 6595_interface branch from d1bdbac to aa4a520 Compare November 7, 2023 12:06

github-actions bot added has-changelog and removed has-unit-tests labels Nov 7, 2023

blackpiglet marked this pull request as ready for review November 7, 2023 12:08

github-actions bot assigned blackpiglet Nov 7, 2023

github-actions bot requested review from Lyndon-Li and qiuming-best November 7, 2023 12:08

blackpiglet requested review from reasonerjt, shubham-pampattiwar and sseago November 7, 2023 12:08

blackpiglet force-pushed the 6595_interface branch from aa4a520 to 6a37cb1 Compare November 7, 2023 12:12

blackpiglet requested a review from allenxu404 November 7, 2023 12:15

blackpiglet force-pushed the 6595_interface branch from 6a37cb1 to 5724f83 Compare November 7, 2023 12:53

draghuram reviewed Nov 7, 2023

View reviewed changes

design/pv_backup_info.md Outdated Show resolved Hide resolved

design/pv_backup_info.md Outdated Show resolved Hide resolved

pkg/volume/volume_info_common.go Show resolved Hide resolved

pkg/volume/volume_info_v1.go Outdated Show resolved Hide resolved

draghuram mentioned this pull request Nov 7, 2023

Add the PV backup information design document. #6962

Merged

3 tasks

blackpiglet force-pushed the 6595_interface branch 2 times, most recently from a9670bb to 85815ee Compare November 8, 2023 02:21

github-actions bot added the has-unit-tests label Nov 8, 2023

anshulahuja98 reviewed Nov 8, 2023

View reviewed changes

design/pv_backup_info.md Show resolved Hide resolved

anshulahuja98 requested changes Nov 8, 2023

View reviewed changes

design/pv_backup_info.md Show resolved Hide resolved

allenxu404 approved these changes Nov 9, 2023

View reviewed changes

blackpiglet force-pushed the 6595_interface branch from 5d27a34 to 4789664 Compare November 9, 2023 15:52

allenxu404 mentioned this pull request Nov 10, 2023

The information of PV is lost if it's restored via podvolume path #6435

Closed

Lyndon-Li previously approved these changes Nov 10, 2023

View reviewed changes

Lyndon-Li reviewed Nov 10, 2023

View reviewed changes

pkg/volume/volume_info_common.go Show resolved Hide resolved

pkg/volume/volume_info_v1.go Outdated Show resolved Hide resolved

blackpiglet dismissed Lyndon-Li’s stale review via 253b24c November 11, 2023 03:32

blackpiglet force-pushed the 6595_interface branch 2 times, most recently from 253b24c to 989cdc1 Compare November 11, 2023 03:36

Lyndon-Li reviewed Nov 13, 2023

View reviewed changes

pkg/volume/volume_info_common.go Show resolved Hide resolved

design/pv_backup_info.md Show resolved Hide resolved

pkg/volume/volume_info_v1.go Outdated Show resolved Hide resolved

blackpiglet force-pushed the 6595_interface branch 4 times, most recently from 2a0454b to 11047b1 Compare November 17, 2023 03:49

Lyndon-Li reviewed Nov 17, 2023

View reviewed changes

pkg/volume/volume_info_common.go Outdated Show resolved Hide resolved

pkg/volume/volume_info_common.go Show resolved Hide resolved

blackpiglet force-pushed the 6595_interface branch from 11047b1 to ed39e1b Compare November 17, 2023 08:03

Lyndon-Li reviewed Nov 17, 2023

View reviewed changes

pkg/volume/volume_info_common.go Show resolved Hide resolved

blackpiglet force-pushed the 6595_interface branch 2 times, most recently from 746a675 to 2797d50 Compare November 17, 2023 08:30

anshulahuja98 previously approved these changes Nov 17, 2023

View reviewed changes

Add VolumeInfo metadata structures and object get method.

b440a4f

Modify design according to comments. Add PVInfo structure. Add backup VolumeInfo's object storage's put and get methods. Signed-off-by: Xun Jiang <[email protected]>

blackpiglet dismissed anshulahuja98’s stale review via b440a4f November 17, 2023 09:23

blackpiglet force-pushed the 6595_interface branch from 2797d50 to b440a4f Compare November 17, 2023 09:23

Lyndon-Li approved these changes Nov 17, 2023

View reviewed changes

ywk253100 approved these changes Nov 17, 2023

View reviewed changes

ywk253100 merged commit 939dd71 into vmware-tanzu:main Nov 17, 2023
24 checks passed

Lyndon-Li mentioned this pull request Nov 21, 2023

6595 volumeinfo generate #7100

Merged

3 tasks

allenxu404 mentioned this pull request Dec 12, 2023

Add finalizing status and controller to restore workflow #7183

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add VolumeInfo metadata structures. #7070

Add VolumeInfo metadata structures. #7070

blackpiglet commented Nov 7, 2023 •

edited

Loading

blackpiglet commented Nov 7, 2023

blackpiglet commented Nov 7, 2023

codecov bot commented Nov 7, 2023 •

edited

Loading

draghuram left a comment

Add VolumeInfo metadata structures. #7070

Add VolumeInfo metadata structures. #7070

Conversation

blackpiglet commented Nov 7, 2023 • edited Loading

Please add a summary of your change

Does your change fix a particular issue?

Please indicate you've done the following:

blackpiglet commented Nov 7, 2023

blackpiglet commented Nov 7, 2023

codecov bot commented Nov 7, 2023 • edited Loading

Codecov Report

draghuram left a comment

Choose a reason for hiding this comment

blackpiglet commented Nov 7, 2023 •

edited

Loading

codecov bot commented Nov 7, 2023 •

edited

Loading