-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the PV backup information design document. #6962
Conversation
52b3737
to
459bf20
Compare
459bf20
to
74ecc41
Compare
Codecov Report
@@ Coverage Diff @@
## main #6962 +/- ##
==========================================
+ Coverage 60.80% 61.14% +0.33%
==========================================
Files 250 252 +2
Lines 26652 26916 +264
==========================================
+ Hits 16205 16457 +252
+ Misses 9297 9295 -2
- Partials 1150 1164 +14 |
f5919b5
to
2b632b7
Compare
2b632b7
to
d5c669f
Compare
d5c669f
to
e86b9c0
Compare
e86b9c0
to
bc3e965
Compare
3f913dd
to
35b42a6
Compare
Signed-off-by: Xun Jiang <[email protected]>
35b42a6
to
23b9484
Compare
|
||
CSISnapshotInfo CSISnapshotInfo | ||
SnapshotDataMoveInfo SnapshotDataMoveInfo | ||
NativeSnapshotInfo VeleroNativeSnapshotInfo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blackpiglet Should this be CloudProviderSnapshotInfo
/ CloudStorageSnapshotInfo
/ ClusterStorageSnapshotInfo
instead ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does have a point. The Velero native snapshot is actually a cloud storage snapshot, but the Velero Native Snapshot is a widely used termination in the Velero code and document.
I think we should keep it consistent here.
But I will add more comments on the structure definition to explain what it actually does.
CSISnapshotInfo CSISnapshotInfo | ||
SnapshotDataMoveInfo SnapshotDataMoveInfo | ||
NativeSnapshotInfo VeleroNativeSnapshotInfo | ||
PVBInfo PodVolumeBackupInfo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we are adding PodVolumeBackupInfo
, Shouldn't the DataUploadInfo
be added too ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SnapshotDataMovementInfo
covers the snapshot data movement information. That structure covers the DataUpload information.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
This design is used to add the design document to address these issues:
pv-backup-info
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.