Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6595 volumeinfo generate #7100

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Nov 14, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@blackpiglet blackpiglet added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Nov 14, 2023
@blackpiglet blackpiglet force-pushed the 6595_volumeinfo_generate branch 3 times, most recently from 98ae12a to 3eebcec Compare November 15, 2023 04:17
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (939dd71) 61.16% compared to head (7f52321) 61.68%.
Report is 10 commits behind head on main.

Files Patch % Lines
pkg/controller/backup_controller.go 96.22% 7 Missing and 3 partials ⚠️
pkg/backup/snapshots.go 0.00% 9 Missing ⚠️
pkg/backup/item_backupper.go 77.41% 5 Missing and 2 partials ⚠️
pkg/client/factory.go 0.00% 2 Missing and 1 partial ⚠️
pkg/cmd/server/server.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7100      +/-   ##
==========================================
+ Coverage   61.16%   61.68%   +0.52%     
==========================================
  Files         258      258              
  Lines       27353    27613     +260     
==========================================
+ Hits        16730    17034     +304     
+ Misses       9437     9387      -50     
- Partials     1186     1192       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet blackpiglet force-pushed the 6595_volumeinfo_generate branch 7 times, most recently from d207746 to 12a6235 Compare November 17, 2023 12:41
@github-actions github-actions bot removed has-changelog Area/Design Design Documents labels Nov 17, 2023
@github-actions github-actions bot added the Area/Design Design Documents label Nov 20, 2023
@blackpiglet blackpiglet force-pushed the 6595_volumeinfo_generate branch 5 times, most recently from dcecc62 to fab6e2c Compare November 21, 2023 10:07
@blackpiglet blackpiglet force-pushed the 6595_volumeinfo_generate branch 3 times, most recently from e4d6e18 to 730d7f9 Compare November 21, 2023 14:40
@blackpiglet blackpiglet marked this pull request as ready for review November 21, 2023 14:43
@blackpiglet blackpiglet removed the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Nov 21, 2023
pkg/controller/backup_controller.go Outdated Show resolved Hide resolved
pkg/controller/backup_controller.go Outdated Show resolved Hide resolved
pkg/controller/backup_controller.go Show resolved Hide resolved
pkg/controller/backup_controller.go Outdated Show resolved Hide resolved
Remove CSI VolumeSnapshot listter and the informer.
Add download the VolumeInfos metadata for backup.

Signed-off-by: Xun Jiang <[email protected]>
@ywk253100 ywk253100 merged commit 5c958d8 into vmware-tanzu:main Nov 22, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants