Bring ValueTriple into alignment with upcoming rev06 #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-fossati
changed the title
comid/measurement.go
Outdated
There was a problem hiding this comment.
Not sure why these changes are needed. I suggest to revert this file to the original.
There was a problem hiding this comment.
Sorry not clear what you meant? The changes in measurement.go line 776 onwards was present earlier, for multiplicity which is now restored as part of reverting the commit?
yogeshbdeshpande
commented
Oct 3, 2024
comid/measurement.go
Outdated
There was a problem hiding this comment.
Sorry not clear what you meant? The changes in measurement.go line 776 onwards was present earlier, for multiplicity which is now restored as part of reverting the commit?
yogeshbdeshpande
force-pushed
the
mutliple-meas
branch
2 times, most recently
from
e3400bc
to
bfe0d04
Compare
…h rev05" Revert the fix applied for aligning Value Triples with rev05 This reverts commit be7ec48.
Signed-off-by: Yogesh Deshpande <[email protected]>
yogeshbdeshpande
force-pushed
the
mutliple-meas
branch
from
bfe0d04
to
90ec56f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit be7ec48.