Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Introduce Multiplicity of Measurements in Value Triples #127

Closed
wants to merge 1 commit into from

Conversation

yogeshbdeshpande
Copy link
Contributor

@yogeshbdeshpande yogeshbdeshpande commented Oct 1, 2024

This PR introduces multiplicity of measurement-map in value triples, to align it with the latest CoRIM Draft.

Fixes #128

@yogeshbdeshpande yogeshbdeshpande changed the title Re-Introduce Multiplicity of Measurements for an Environment Re-Introduce Multiplicity of Measurements in Value Triples Oct 1, 2024
@thomas-fossati
Copy link
Contributor

thomas-fossati commented Oct 3, 2024

It'd be much cleaner (and easier to review) if this PR was split into two separate commits:

  1. the one that reverts be7ec48
  2. the one that adds the new test cases

@thomas-fossati
Copy link
Contributor

Also, please use the conventional commits conventions when crafting the commit messages.

@yogeshbdeshpande
Copy link
Contributor Author

This will be progressed by PR #130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Value Triples needs updating to latest CoRIM Draft
2 participants