-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pulseaudio direct connection #852
Conversation
Tested on Lenovo-X1 (flashed to the SSD) (commit: 32d481e) Working: Notes: when 3,5mm audio is plugin during reboot operation, audio don't heard from 3.5 mm headset or from internal speaker. Need to plug out and plugin the 3,5 mm headset and after that audio heard via headset. Same issue with main x1 build. |
The Dell-Latitude needed to be tested also?
|
|
@josa41 is the open conversation going to be resolved in this PR? it needs to be resolved before merging is possible |
This PR would fix 3 issues and cause one (some apps may not respect export PULSE_SERVER env variable).
I think the main question is do we have an app which would not respect the PULSE_SERVER variable? |
that i am not sure. and by the |
This has to be tested, but I seen some applications that don't read the pulse environment variable and pass it to pulse connect function: https://docs.rs/libpulse-binding/latest/src/libpulse_binding/context/mod.rs.html#316-342 GitHub search would reveal many projects. One case I faced is ironbar: https://github.com/JakeStanger/ironbar/blob/6240b4b4fd2b42898860b656b5fe3f946d11db2a/src/clients/volume/mod.rs#L118 I had to create a patch for it to connect to audio-vm when I was testing it. This PR is a good step, I agree with this change, but I think it is a good idea to allow an option to still keep running a local pulseaudio server (default to false). This way this issue wouldn't cause breaking changes to applications, and there wouldn't be a need to revert this change. |
Now I like your idea. I did not like to have both env and pulse service running at the same time on all app vms but with the variable its good middle ground. I'll update the PR. Thanks. |
32d481e
to
a0b2d85
Compare
Set Ghaf audio apps to directly connect to audiovm with pulseaudio With this change we can also remove the pulseaudio don't move patch Signed-off-by: Jon Sahlberg <[email protected]>
a0b2d85
to
a8d0295
Compare
Set Ghaf audio apps to directly connect to audiovm with pulseaudio
Description of changes
Makes app vms use audiovm pulseaudio directly without application audio tunneling
With this change the pulseaudio don't move patch is not needed
Checklist for things done
x86_64
aarch64
riscv64
make-checks
and it passesnixos-rebuild ... switch
Appvm audio routing has changed, audio should work same as before
Instructions for Testing