Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify audio-ctrl helper package #854

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

josa41
Copy link
Contributor

@josa41 josa41 commented Oct 18, 2024

Description of changes

Minor change to simplify audio-ctrl helper script
The script is used by eww-bar and desktop for hardware volume buttons

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
  • Is this a new feature
    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?

@josa41 josa41 temporarily deployed to internal-build-workflow October 18, 2024 08:25 — with GitHub Actions Inactive
@josa41 josa41 added the Needs Testing CI Team to pre-verify label Oct 18, 2024
@johannarautanen
Copy link

Tested on Lenovo-X1 (flashed to the SSD) (commit: f87bd8a)

Working:
-internal, usb, 3,5mm and bluetooth audio works with Chromium, Microsoft(365,outlook,Teams), slack, video editor.
-volume control works via bar and keyboard-buttons and ghafaudiocontrolstandalone
-all other ghaf apps can be launched
-ci-test automation cases ok (older auitomation tests before 18th oct)

Notes:
After you close chromium, business and comms-applications, the "GhafAudioControlStandlone"-app still shows the tunnels:
screenshot-20241021-10-38-15

@josa41
Copy link
Contributor Author

josa41 commented Oct 21, 2024

Tested on Lenovo-X1 (flashed to the SSD) (commit: f87bd8a)

Working: -internal, usb, 3,5mm and bluetooth audio works with Chromium, Microsoft(365,outlook,Teams), slack, video editor. -volume control works via bar and keyboard-buttons and ghafaudiocontrolstandalone -all other ghaf apps can be launched -ci-test automation cases ok (older auitomation tests before 18th oct)

Notes: After you close chromium, business and comms-applications, the "GhafAudioControlStandlone"-app still shows the tunnels: screenshot-20241021-10-38-15

Yes it can be that the tunnels are still shown in the list but it has got nothing to do with this ticket. :)

The tunnels showing can be fixed with for example as #852 or then the audio control application could show the actual pulseaudio data streams (sink-input / source-outouts) instead of the ghaf-audio tcp tunnels (sink / source).

I can have a chat with @baz2142 about audio control app.

@johannarautanen johannarautanen added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon and removed Needs Testing CI Team to pre-verify labels Oct 21, 2024
@brianmcgillion brianmcgillion merged commit 6a914ac into tiiuae:main Oct 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants