-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GhafPkgs] Update Audio Control #850
Conversation
a8b949b
to
f5d5968
Compare
Add AppVM names support Signed-off-by: Nikita Bazulin <[email protected]>
f5d5968
to
8942c03
Compare
Also noticed now that the audio streams stay open although corresponding apps are closed. Is this ok? |
I think, now every AppVM has it's own stream for the all apps. So it's not like every application inside an AppVM creates a stream, but every application inside it goes through the same stream Is it correct, @josa41? |
Yes in current version the app-vm created the pulseaudio tcp tunnel open even though the app is closed. The actual pulseaudio application audio stream is closed but tcp tunnel that carries the stream stays open. I have made a patch that would fix the tcp stream so that the connection will get closed along with the app: #852 |
Add AppVM names support. Now you can see, which stream belongs to which AppVM
Description of changes
Checklist for things done
x86_64
aarch64
riscv64
make-checks
and it passesnixos-rebuild ... switch
Instructions for Testing
Run Audio Control
Run Chromium and check, that steams appear under "Chromium-appvm" name
Another audio apps, if it is possible