-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] version.py
: guard git
calls during wheel builds (sans .git
)
#2590
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2590 +/- ##
=======================================
Coverage 90.26% 90.26%
=======================================
Files 37 37
Lines 4007 4007
=======================================
Hits 3617 3617
Misses 390 390
Flags with carried forward coverage won't be shown. Click here to find out more.
|
prevent `fatal: not a git repository` logspam
version.py
: guard git
calls during wheel builds (sans .git
)version.py
: guard git
calls during wheel builds (sans .git
)
"sdist & wheels" GHA succeeded on this branch. Here's a local test I also ran:
|
I manually triggered the packaging CI workflow for this branch, and it passed https://github.com/single-cell-data/TileDB-SOMA/actions/runs/9161462896 |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-1.11 release-1.11
# Navigate to the new working tree
cd .worktrees/backport-release-1.11
# Create a new branch
git switch --create backport-2590-to-release-1.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 60344e20d2d19333a1d54fca74af297ca0a214ac
# Push it to GitHub
git push --set-upstream origin backport-2590-to-release-1.11
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-1.11 Then, create a pull request where the |
Issue and/or context: #2588
Changes:
Make sure "version inference from Git tags" fails silently/gracefully when run outside of a Git clone (e.g. during wheel build).
Notes for Reviewer:
Here is a passing "sdist & wheel build" GHA dispatched from this branch.