Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python/ci] Build wheel from sdist outside of Git repository #2589

Merged
merged 1 commit into from
May 20, 2024

Conversation

jdblischak
Copy link
Collaborator

Issue and/or context:

The recent update to version.py broke package builds that rely on RELEASE-VERSION outside the context of a Git repo

xref: #2588, #2563, TileDB-Inc/tiledbsoma-feedstock#153 (comment)

Changes:

This is exactly the type of build error that my packaging CI workflow is supposed to catch. I've updated it so that it now extracts the sdist outside of the Git repo that was cloned, which should catch this type of error in the future

Notes for Reviewer:

The packaging CI is expected to fail. I will rebase it after we merge the fix from @ryan-williams

@jdblischak jdblischak self-assigned this May 20, 2024
@jdblischak
Copy link
Collaborator Author

As expected, the "Wheel from sdist" jobs failed with:

subprocess.CalledProcessError: Command '('git', 'tag', '--list', '--sort=v:refname', '[0-9].*.*')' returned non-zero exit status 128.

@jdblischak
Copy link
Collaborator Author

Potential fix from @ryan-williams in #2590. I manually triggered the branch rw/ver to run the packaging CI workflow

https://github.com/single-cell-data/TileDB-SOMA/actions/runs/9161462896

(in the future this CI will automatically be triggered when version.py is edited)

@@ -351,6 +353,7 @@ jobs:
steps:
- uses: actions/checkout@v4
with:
path: TileDB-SOMA
fetch-depth: 0 # for setuptools-scm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting, fetch-depth: 0 shouldn't be necessary anymore (since #2563). Fine to leave it in as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it isn't strictly necessary. But I want to keep this test job as close to as possible to the upstream official packaging job that it is designed to emulate

- name: Checkout TileDB-SOMA
uses: actions/checkout@v3
with:
fetch-depth: 0 # ensure we get all tags to inform package version determination

@jdblischak
Copy link
Collaborator Author

Rebased onto 60344e2 to incorporate the recently merged #2590

@jdblischak jdblischak merged commit dc316b1 into single-cell-data:main May 20, 2024
12 checks passed
@jdblischak jdblischak deleted the ci-packaging-nogit branch May 20, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants