-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python/ci] Build wheel from sdist outside of Git repository #2589
[python/ci] Build wheel from sdist outside of Git repository #2589
Conversation
As expected, the "Wheel from sdist" jobs failed with: subprocess.CalledProcessError: Command '('git', 'tag', '--list', '--sort=v:refname', '[0-9].*.*')' returned non-zero exit status 128. |
Potential fix from @ryan-williams in #2590. I manually triggered the branch rw/ver to run the packaging CI workflow https://github.com/single-cell-data/TileDB-SOMA/actions/runs/9161462896 (in the future this CI will automatically be triggered when |
@@ -351,6 +353,7 @@ jobs: | |||
steps: | |||
- uses: actions/checkout@v4 | |||
with: | |||
path: TileDB-SOMA | |||
fetch-depth: 0 # for setuptools-scm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting, fetch-depth: 0
shouldn't be necessary anymore (since #2563). Fine to leave it in as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it isn't strictly necessary. But I want to keep this test job as close to as possible to the upstream official packaging job that it is designed to emulate
TileDB-SOMA/.github/workflows/python-packaging.yml
Lines 27 to 30 in 6108f73
- name: Checkout TileDB-SOMA | |
uses: actions/checkout@v3 | |
with: | |
fetch-depth: 0 # ensure we get all tags to inform package version determination |
cac3aff
to
f5f9b31
Compare
Issue and/or context:
The recent update to
version.py
broke package builds that rely onRELEASE-VERSION
outside the context of a Git repoxref: #2588, #2563, TileDB-Inc/tiledbsoma-feedstock#153 (comment)
Changes:
This is exactly the type of build error that my packaging CI workflow is supposed to catch. I've updated it so that it now extracts the sdist outside of the Git repo that was cloned, which should catch this type of error in the future
Notes for Reviewer:
The packaging CI is expected to fail. I will rebase it after we merge the fix from @ryan-williams