Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Python client no longer able to use version from file RELEASE-VERSION #2588

Closed
jdblischak opened this issue May 20, 2024 · 3 comments
Closed
Assignees

Comments

@jdblischak
Copy link
Collaborator

PR #2563 was merged Thursday. It updated version.py to improve the auto-generated versions for the Python package. However, this seems to have broken the package build workflow that relies on obtaining the version from the file RELEASE-VERSION instead of the Git repository.

The nightly jobs that build wheels from an sdist (which has RELEASE-VERSION bundled with it) are failing because version.py is running a Git command which fails in this context with no Git repository

xref: #2578 (comment), #2583, #2584, #2585

subprocess.CalledProcessError: Command '('git', 'tag', '--list', '--sort=v:refname', '[0-9].*.*')' returned non-zero exit status 128.

note to self: this scheduled job runs at 5:44 AM each day, which is why the job passed on Thursday and the first failure was Friday morning

The nightly tiledbsoma-feedstock builds are failing with a similar albeit different error:

xref: TileDB-Inc/tiledbsoma-feedstock#153 (comment)

    File "${SRC_DIR}/apis/python/version.py", line 124, in get_latest_remote_tag
      raise RuntimeError(f"No tags found in remote {remote}")
  RuntimeError: No tags found in remote origin

The conda recipe build script creates RELEASE-VERSION using the version specified in the recipe (source): echo "$PKG_VERSION" >> RELEASE-VERSION

Frustratingly my packaging CI job didn't catch this. Even though I build from an sdist, I unpacked it within the Git repository, so version.py was still able to successfully run Git commands. I'll update the pipeline to be more rigorous.

@ryan-williams
Copy link
Member

ryan-williams commented May 20, 2024

I dispatched a "sdist & wheel" GHA here, from main, now that #2590 is merged; I expect it to pass, and the daily to go green tmrw.

lmk if there's anything else I should look at here @jdblischak, and apologies for breaking this build!

@ryan-williams
Copy link
Member

ryan-williams commented May 21, 2024

Confirming: scheduled "sdist & wheel" GHA passed today https://github.com/single-cell-data/TileDB-SOMA/actions/runs/9172528963

@jdblischak
Copy link
Collaborator Author

I confirmed that this is also now fixed in the nightly build of tiledbsoma-feedstock. The one currently passing build was able to run version.py without a problem. Note that the nightly feedstock build is a bit different since it clones the Git repo, but presumably the standard build with the GitHub release tarball will also work since we fixed the wheel from sdist builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants