Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make node name unique with random suffix #500

Closed
wants to merge 1 commit into from

Conversation

dawonn-haval
Copy link

Fixes #425.

I have found a great deal of stability improvement after ensuring all node names are unique, regardless of the fact that it shouldn't affect DDS. It's also nice to eliminate the warnings from ros2 topic list and launch_ros about duplicate node names. Similar patches for launch_ros, ros2cli incoming.

@dawonn-haval dawonn-haval force-pushed the unique-name branch 2 times, most recently from 5ee3133 to 4fad3a4 Compare August 8, 2020 20:41
@dawonn-haval
Copy link
Author

image

Flakey CI test, or did I not run this correctly on my local machine?

@Karsten1987
Copy link
Collaborator

@dawonn-haval that's certainly a good thing to have. Do you mind rebasing your PR?

@audrow audrow changed the base branch from master to rolling June 28, 2022 14:50
@audrow audrow requested a review from a team as a code owner June 28, 2022 14:50
@audrow audrow requested review from emersonknapp and hidmic and removed request for a team June 28, 2022 14:50
@gbiggs
Copy link
Member

gbiggs commented Jun 28, 2022

@dawonn-haval If you can rebase this, I think we can move forward on getting it merged.

@MichaelOrlov
Copy link
Contributor

@dawonn-haval @gbiggs This issue has been stale for some significant amount of time and our code base and feature set went far away from what it was when this PR was actual.

Currently we even don't have such rosbag2_transport.cpp file in rosbag2 any more.
I would oppose to the suggestion from this PR to add random numbers to the node name in rosbag2.
And the reason for that is that it will be very useful in some cases to have multiple instances of the rosbag2 with the same node name.
In particular if one would try to establish aka distributed recording or distributed replay.
It will be useful to send one service request for start recording and all instances on all HWs will start recording almost at the same time and finish the same way.
To make it more flexible and solve problem with name collisions for all other cases it will be better to bring new command line option to be able to specify node name for rosbag2 play and record verbs.

Giving all listed above I am closing this PR since it is not possible to rebase it and it was proposed another solution for naming problem.
If someone want to address node names issue please open up a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Name rosbag2 node uniquely
4 participants