Fix rosbag2_tests resource files and play_end_to_end test #362
Conversation
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
rosbag2_tests/test/rosbag2_tests/test_rosbag2_info_end_to_end.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Mabel Zhang <[email protected]>
|
|
Updated .repos file. Retry:
|
There was a problem hiding this comment.
Warnings were addressed in #360. If you rebase, you should have green CI.
|
Rebased and new set of CI:
Actually it looks like the version run with CI above has already been rebased, for I only forked this branch today, and the fix was yesterday. I had to update my workspace to build with So I don't know where that warning is coming from. Not from this branch - grep doesn't even show I'm looking at all the CIs here https://ci.ros2.org/job/ci_linux/ , and there hasn't been one green. I clicked on a few random ones, and they all have the same warning. Maybe there is one repo that hasn't been updated with the new command. |
|
That's a known issue. There's an outstanding PR for tracing tools to address the deprecation warning. |
|
Looking at CI, I think the |
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
|
No more test failures on Linux & macOS.
|
|
@mabelzhang yes that's a known issue on Windows. This solution is to refactor the E2E tests to use launch_testing (Some of the work started in #351 and #347). |
Re-recorded the
cdr_testandwrong_rmw_testbag files inrosbag2_testswith the latestmasterbranch, metadata version 4.Updated
play_end_to_endtest to reflect the changes and re-enabled this test in CMakeLists.txt.Only change in the bag is that the field
test_msgs::msg::BasicTypes::string_valuedoesn't exist anymore, so it is replaced with aint32_value.The messages are produced with a simple script here.