Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[humble] Make snapshot writing into a new file each time it is triggered (backport #1842) #1850

Open
wants to merge 1 commit into
base: humble
Choose a base branch
from
Open

[humble] Make snapshot writing into a new file each time it is triggered (backport #1842) #1850

wants to merge 1 commit into from
+295 −2

Commits on Nov 1, 2024

  1. Make snapshot writing into a new file each time it is triggered (#1842) 

    * Make snapshot writing into a new file each time when it is triggered

- Note. Snapshot now became a blocking call and mutually exclusive with
writer::write(message) method to avoid race conditions.
i.e. blocking the same writer_mutex_

Signed-off-by: Michael Orlov <[email protected]>

* Add unit test to make sure that snapshot writing in the new file

Co-authored-by: Clemens Mühlbacher <[email protected]>
Signed-off-by: Michael Orlov <[email protected]>

* Add support for snapshot with file compression

Signed-off-by: Michael Orlov <[email protected]>

* Rename newly added tests to avoid misunderstanding

Signed-off-by: Michael Orlov <[email protected]>

* Address review comments in tests

Signed-off-by: Michael Orlov <[email protected]>

* Change order of includes in the test_sequential_compression_writer.cpp

Signed-off-by: Michael Orlov <[email protected]>

* Update metadata_.message_count unconditionally in write_messages(..)

Signed-off-by: Michael Orlov <[email protected]>

---------

Signed-off-by: Michael Orlov <[email protected]>
Co-authored-by: Clemens Mühlbacher <[email protected]>
(cherry picked from commit 3f2281f)
    @MichaelOrlov @mergify
    MichaelOrlov authored and mergify[bot] committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    0919d48 View commit details
    Browse the repository at this point in the history