Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in a library prefix for lz4 from conda on Windows. #1846

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Add in a library prefix for lz4 from conda on Windows. #1846

merged 2 commits into from
Oct 30, 2024

Conversation

clalancette
Copy link
Contributor

The comment explains why we need to do this.

Opening as a draft for right now until I run CI with Conda.

@clalancette
Add in a library prefix for lz4 from conda on Windows.
61a55a1 
The comment explains why we need to do this.

Signed-off-by: Chris Lalancette <[email protected]>
@clalancette
Silly fixup.
287d4ba 
Signed-off-by: Chris Lalancette <[email protected]>
@clalancette
Copy link
Contributor Author

This seems to have worked (see https://ci.ros2.org/view/All/job/test_ci_windows/590), so I'm marking it as "Ready for review" and I'll run full CI on it.

@clalancette clalancette marked this pull request as ready for review October 30, 2024 12:22
@clalancette clalancette requested a review from a team as a code owner October 30, 2024 12:22
@clalancette clalancette requested review from MichaelOrlov and hidmic and removed request for a team October 30, 2024 12:22
@clalancette
Copy link
Contributor Author

Pulls: #1846
Gist: https://gist.githubusercontent.com/clalancette/cf78cbb5356352239e74d7046884b1b2/raw/2fe4b8f9b36cc0cd7f27a74310fe3d75c12d4298/ros2.repos
BUILD args: --packages-above-and-dependencies liblz4_vendor
TEST args: --packages-above liblz4_vendor
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14755

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

christophebedard
christophebedard approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@clalancette clalancette merged commit ee7f68a into rolling Oct 30, 2024
12 checks passed
@clalancette clalancette deleted the clalancette/fix-find-lz4-conda branch October 30, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophebedard christophebedard christophebedard approved these changes

@MichaelOrlov MichaelOrlov Awaiting requested review from MichaelOrlov MichaelOrlov is a code owner automatically assigned from ros2/tooling-reviewers

@hidmic hidmic Awaiting requested review from hidmic hidmic is a code owner automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clalancette @christophebedard