Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Update metadata with new file_info before saving it the first time in the file #1843

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

Bugfix: Update metadata with new file_info before saving it the first time in the file #1843

wants to merge 1 commit into from
+10 −10

Conversation

MichaelOrlov
Copy link
Contributor

This PR is a bug fix for missing file_info for newly created file in saved metadata.

When we are switching to new storage, the correct behavior shall be as follows:

  1. Save metadata to storage
  2. Close current storage
  3. Open new storage for read_write
  4. Update metadata with a newly created file
  5. Save metadata to storage

@MichaelOrlov MichaelOrlov marked this pull request as ready for review October 27, 2024 05:58
@MichaelOrlov MichaelOrlov requested a review from a team as a code owner October 27, 2024 05:58
@MichaelOrlov MichaelOrlov requested review from emersonknapp, jhdcs, christophebedard and fujitatomoya and removed request for a team, emersonknapp and jhdcs October 27, 2024 05:58
@MichaelOrlov
Copy link
Contributor Author

@ros-pull-request-builder retest this please

christophebedard
christophebedard approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@MichaelOrlov MichaelOrlov force-pushed the morlov/update_metadata_before_saving branch from 4b35616 to 07e5672 Compare November 1, 2024 23:43
@MichaelOrlov
Copy link
Contributor Author

Pulls: #1843
Gist: https://gist.githubusercontent.com/MichaelOrlov/9e3fdad4ca5ccf152d70e2b2ddfced12/raw/e9f907208e030ed0d619019b76d2f62f11d9917b/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_compression rosbag2_cpp rosbag2_tests
TEST args: --packages-above rosbag2_compression rosbag2_cpp rosbag2_tests
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14778

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@christophebedard
Copy link
Member

Something weird happened in that Windows job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophebedard christophebedard christophebedard approved these changes

@fujitatomoya fujitatomoya Awaiting requested review from fujitatomoya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelOrlov @christophebedard