Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make snapshot writing into a new file each time it is triggered #1842

Merged
merged 7 commits into from
Nov 1, 2024
Merged

Make snapshot writing into a new file each time it is triggered #1842

merged 7 commits into from
Nov 1, 2024

Commits on Oct 26, 2024

  1. Make snapshot writing into a new file each time when it is triggered 

    - Note. Snapshot now became a blocking call and mutually exclusive with
writer::write(message) method to avoid race conditions.
i.e. blocking the same writer_mutex_

Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    e46c7f0 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2024

  1. Add unit test to make sure that snapshot writing in the new file 

    Co-authored-by: Clemens Mühlbacher <[email protected]>
Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov @cmuehlbacher
    MichaelOrlov and cmuehlbacher committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    169c6b4 View commit details
    Browse the repository at this point in the history

  2. Add support for snapshot with file compression 

    Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    f1c36b9 View commit details
    Browse the repository at this point in the history

  3. Rename newly added tests to avoid misunderstanding 

    Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    92a435b View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Address review comments in tests 

    Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    90f035a View commit details
    Browse the repository at this point in the history

  2. Change order of includes in the test_sequential_compression_writer.cpp 

    Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    4b62921 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Update metadata_.message_count unconditionally in write_messages(..) 

    Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    8344e79 View commit details
    Browse the repository at this point in the history