-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[humble] Fix typo to properly restore SIGINT handler #1687
Conversation
Signed-off-by: Eric Cousineau <[email protected]>
4afbdf3
to
32982e7
Compare
It appears that this typo is also present in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good eye 👁️ lgtm with green CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EricCousineau-TRI While changes in this PR will certainly fix a typo and will properly return the original signal handler for SIGINT
, but it will not solve a problem reported in the #1686.
Among properly returning original signal handlers need yet memorize the deferred signal in the static member variable and call the original SIGINT
handler on exit. See https://github.com/ros2/rosbag2/pull/1685/files#diff-c85fd024e7d68c762d60d25e2ba155bcc527f04c937ed09adc893ea241fdc61cR241-R254 for reference.
Also, I would encourage you to cherry-pick my newly added test_process_sigint_in_recorder(tmp_path, storage_id, capfd):
unit test from the #1685
https://github.com/ros2/rosbag2/pull/1685/files#diff-f990d34f689d7cde53ab226e2b1b96b5573c4e050ccf698cc182e76bd72fc0eeR88-R129
tio make sure tha the original Python SIGINT handler called.
Pulls: #1687 |
SIGTERM
should beSIGINT
) #1686