Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] Add options to disable signal handling in Player and Recorder Python API #1685

Open
wants to merge 7 commits into
base: rolling
Choose a base branch
from
Open

[wip] Add options to disable signal handling in Player and Recorder Python API #1685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8b43291
Add options to disable signal handling in Player and Recorder Python API
MichaelOrlov Jun 1, 2024
b43820e
Address old uncrustify style warnings
MichaelOrlov Jun 12, 2024
f626764
Move common signal handling functionality to a separate class
MichaelOrlov Aug 17, 2024
299ed19
Fixup for uncrustify
MichaelOrlov Aug 17, 2024
6d94fda
Regenerate Python stub files (.pyi)
MichaelOrlov Aug 17, 2024
01d5d65
Address Windows build failure
MichaelOrlov Sep 4, 2024
12bdf3d
Disable tests that check signal handling on Windows
MichaelOrlov Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions rosbag2_py/rosbag2_py/_transport.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,16 @@ class Player:
def __init__(self) -> None: ...
@overload
def __init__(self, arg0: str) -> None: ...
@overload
def burst(self, storage_options: rosbag2_py._storage.StorageOptions, play_options: PlayOptions, num_messages: int) -> None: ...
@overload
def burst(self, storage_options: rosbag2_py._storage.StorageOptions, play_options: PlayOptions, num_messages: int, enable_signal_handling: bool) -> None: ...
@staticmethod
def cancel() -> None: ...
@overload
def play(self, storage_options: rosbag2_py._storage.StorageOptions, play_options: PlayOptions) -> None: ...
@overload
def play(self, storage_options: rosbag2_py._storage.StorageOptions, play_options: PlayOptions, enable_signal_handling: bool) -> None: ...

class RecordOptions:
all_services: bool
Expand Down Expand Up @@ -77,7 +83,10 @@ class Recorder:
def __init__(self, arg0: str) -> None: ...
@staticmethod
def cancel() -> None: ...
@overload
def record(self, storage_options: rosbag2_py._storage.StorageOptions, record_options: RecordOptions, node_name: str = ...) -> None: ...
@overload
def record(self, storage_options: rosbag2_py._storage.StorageOptions, record_options: RecordOptions, node_name: str, enable_signal_handling: bool) -> None: ...

class ServiceRequestsSource:
__members__: ClassVar[dict] = ... # read-only
Expand Down
Loading
Loading