Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store serialized metadata in MCAP file #1423

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Store serialized metadata in MCAP file #1423

merged 3 commits into from
Sep 25, 2023

Commits on Sep 23, 2023

  1. Store serialized metadata in MCAP file when calling update_metadata() 

    Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    3ed23d0 View commit details
    Browse the repository at this point in the history

  2. Remove ROS_DISTRO key-value from mcap::Metadata 

    - ROS_DISTRO now stored inside serialized metadata

Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    a54fb93 View commit details
    Browse the repository at this point in the history

  3. Fix for test failure on Windows 

    - Use `UnorderedElementsAreArray` for checking
`metadata.topics_with_message_count`.
- The list of the metadata.topics_with_message_count forming from the
 mcap_reader_->channels() which is unordered_map.
 The order of the elements in the unordered_map is unpredictable and
 can vary on different platforms.

Signed-off-by: Michael Orlov <[email protected]>
    @MichaelOrlov
    MichaelOrlov committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    cc6649a View commit details
    Browse the repository at this point in the history