Skip to content

Commit

Permalink
Disable tests that check signal handling on Windows
Browse files Browse the repository at this point in the history
- Rationale: The signal handling on Windows hasn't been implemented yet.

Signed-off-by: Michael Orlov <[email protected]>
  • Loading branch information
MichaelOrlov committed Sep 5, 2024
1 parent 01d5d65 commit 12bdf3d
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions rosbag2_py/test/test_transport.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from pathlib import Path
import re
import signal
import sys
import threading

from common import get_rosbag_options, wait_for
Expand Down Expand Up @@ -87,6 +88,9 @@ def test_recoder_log_level():

@pytest.mark.parametrize('storage_id', TESTED_STORAGE_IDS)
def test_process_sigint_in_recorder(tmp_path, storage_id, capfd):
if sys.platform.startswith('win'):
pytest.skip('Signal handling is not implemented on Windows yet.')

bag_path = tmp_path / 'test_process_sigint_in_recorder'
storage_options, converter_options = get_rosbag_options(str(bag_path), storage_id)

Expand Down Expand Up @@ -131,6 +135,9 @@ def test_process_sigint_in_recorder(tmp_path, storage_id, capfd):

@pytest.mark.parametrize('storage_id', TESTED_STORAGE_IDS)
def test_record_process_sigint_in_python_handler(tmp_path, storage_id, capfd):
if sys.platform.startswith('win'):
pytest.skip('Signal handling is not implemented on Windows yet.')

bag_path = tmp_path / 'test_record_sigint_in_python'
storage_options, converter_options = get_rosbag_options(str(bag_path), storage_id)

Expand Down Expand Up @@ -175,6 +182,9 @@ def test_record_process_sigint_in_python_handler(tmp_path, storage_id, capfd):

@pytest.mark.parametrize('storage_id', TESTED_STORAGE_IDS)
def test_process_sigint_in_player(storage_id, capfd):
if sys.platform.startswith('win'):
pytest.skip('Signal handling is not implemented on Windows yet.')

bag_path = str(RESOURCES_PATH / storage_id / 'talker')
storage_options, converter_options = get_rosbag_options(bag_path, storage_id)

Expand Down Expand Up @@ -211,6 +221,9 @@ def test_process_sigint_in_player(storage_id, capfd):

@pytest.mark.parametrize('storage_id', TESTED_STORAGE_IDS)
def test_play_process_sigint_in_python_handler(storage_id, capfd):
if sys.platform.startswith('win'):
pytest.skip('Signal handling is not implemented on Windows yet.')

bag_path = str(RESOURCES_PATH / storage_id / 'talker')
storage_options, converter_options = get_rosbag_options(bag_path, storage_id)

Expand Down

0 comments on commit 12bdf3d

Please sign in to comment.