Skip to content

Commit

Permalink
Skip check for custom_metadata in test for mcap storage plugin.
Browse files Browse the repository at this point in the history
- Rationale:
Mcap storage doesn't store serialized metadata in bag directly on Iron
and Humble. Backporting of the relevant #1423 is not possible without
updating mcap vendor package to the v1.1.0 because we have dependencies
from the mcap_reader_->metadataIndexes(); API which became available
only in the foxglove/mcap#902

Signed-off-by: Michael Orlov <[email protected]>
  • Loading branch information
MichaelOrlov committed Jun 13, 2024
1 parent cac9ecb commit 0c0b038
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion rosbag2_tests/test/rosbag2_tests/test_reindexer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,15 @@ TEST_P(ReindexTestFixture, test_multiple_files) {

EXPECT_EQ(generated_metadata.storage_identifier, GetParam());
EXPECT_EQ(generated_metadata.version, target_metadata.version);
EXPECT_EQ(generated_metadata.custom_data, target_metadata.custom_data);

if (GetParam() != "mcap") {
// Skip check for mcap storage since it doesn't store serialized metadata in bag directly on
// Iron and Humble. Backporting of the relevant #1423 is not possible without updating
// mcap vendor package to the v1.1.0 because we have dependencies from the
// mcap_reader_->metadataIndexes(); API which became available only in the
// https://github.com/foxglove/mcap/pull/902
EXPECT_EQ(generated_metadata.custom_data, target_metadata.custom_data);
}

for (const auto & gen_rel_path : generated_metadata.relative_file_paths) {
EXPECT_TRUE(
Expand Down

0 comments on commit 0c0b038

Please sign in to comment.