Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a typo in Writing-A-Simple-Cpp-Service-And-Client.rst #4934

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Fix a typo in Writing-A-Simple-Cpp-Service-And-Client.rst #4934

merged 1 commit into from
Jan 14, 2025

Conversation

jihyeseo
Copy link
Contributor

The currently code shows error when the result is success.

kscottz
kscottz approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@kscottz kscottz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jihyeseo this looks good to me. Just to double check, I am assuming you copied this code and ran into this bug?

fujitatomoya
fujitatomoya reviewed Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI workflow

source/Tutorials/Beginner-Client-Libraries/Writing-A-Simple-Cpp-Service-And-Client.rst
@@ -215,7 +215,7 @@ Inside the ``ros2_ws/src/cpp_srvcli/src`` directory, create a new file called ``
request->a = 41;
request->b = 1;
auto result_future = client->async_send_request(request);
if (rclcpp::spin_until_future_complete(node, result_future) ==
if (rclcpp::spin_until_future_complete(node, result_future) !=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this aligns with https://github.com/ros2/examples/blob/4a4082a8db04fd3d587bd0d2052ae0c439e788c6/rclcpp/services/minimal_client/main.cpp#L40

@ahcorde ahcorde added the backport-all backport at reviewers discretion; from rolling to all versions label Jan 14, 2025
@ahcorde ahcorde merged commit 3959d21 into ros2:rolling Jan 14, 2025
4 checks passed
mergify bot pushed a commit that referenced this pull request Jan 14, 2025
@jihyeseo @mergify
Fix a typo in Writing-A-Simple-Cpp-Service-And-Client.rst (#4934)
0087507 
Signed-off-by: Jihye Sofia Seo <[email protected]>
(cherry picked from commit 3959d21)

# Conflicts:
#	source/Tutorials/Beginner-Client-Libraries/Writing-A-Simple-Cpp-Service-And-Client.rst
mergify bot pushed a commit that referenced this pull request Jan 14, 2025
@jihyeseo @mergify
Fix a typo in Writing-A-Simple-Cpp-Service-And-Client.rst (#4934)
332e4f0 
Signed-off-by: Jihye Sofia Seo <[email protected]>
(cherry picked from commit 3959d21)

# Conflicts:
#	source/Tutorials/Beginner-Client-Libraries/Writing-A-Simple-Cpp-Service-And-Client.rst
This was referenced Jan 14, 2025
Merged
Merged
ahcorde added a commit that referenced this pull request Jan 14, 2025
@mergify @jihyeseo @ahcorde
Fix a typo in Writing-A-Simple-Cpp-Service-And-Client.rst (backport #…
d1dc653 
…4934) (#4937)

* Fix a typo in Writing-A-Simple-Cpp-Service-And-Client.rst (#4934)

Signed-off-by: Jihye Sofia Seo <[email protected]>
(cherry picked from commit 3959d21)

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Jihye Sofia Seo <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
ahcorde added a commit that referenced this pull request Jan 14, 2025
@mergify @jihyeseo @ahcorde
Fix a typo in Writing-A-Simple-Cpp-Service-And-Client.rst (backport #…
24c6ebf 
…4934) (#4938)

* Fix a typo in Writing-A-Simple-Cpp-Service-And-Client.rst (#4934)

Signed-off-by: Jihye Sofia Seo <[email protected]>
(cherry picked from commit 3959d21)

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Jihye Sofia Seo <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
@jihyeseo
Copy link
Contributor Author

@jihyeseo this looks good to me. Just to double check, I am assuming you copied this code and ran into this bug?

Yes. I am learning ROS, and I am planning to run every tutorial.
I did test the above code and found the typo. Thanks for the quick response.

@christophebedard
Copy link
Member

This should not have been backported. The content on other branches is different, so the if condition should not be changed (#4937, #4938).

This was referenced Jan 14, 2025
Merged
Merged
@christophebedard
Copy link
Member

christophebedard commented Jan 14, 2025 •
edited
Loading

See the following revert PRs for the backport PRs:

@christophebedard christophebedard removed the backport-all backport at reviewers discretion; from rolling to all versions label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@ahcorde ahcorde ahcorde approved these changes

@kscottz kscottz kscottz approved these changes

@clalancette clalancette Awaiting requested review from clalancette clalancette is a code owner

@audrow audrow Awaiting requested review from audrow audrow is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jihyeseo @christophebedard @kscottz @ahcorde @fujitatomoya