Skip to content

Commit

Permalink
Fix a typo in Writing-A-Simple-Cpp-Service-And-Client.rst (backport #…
Browse files Browse the repository at this point in the history
…4934) (#4937)

* Fix a typo in Writing-A-Simple-Cpp-Service-And-Client.rst (#4934)

Signed-off-by: Jihye Sofia Seo <[email protected]>
(cherry picked from commit 3959d21)

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Jihye Sofia Seo <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
  • Loading branch information
3 people authored Jan 14, 2025
1 parent f8f6e2a commit d1dc653
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ Inside the ``ros2_ws/src/cpp_srvcli/src`` directory, create a new file called ``

auto result = client->async_send_request(request);
// Wait for the result.
if (rclcpp::spin_until_future_complete(node, result) ==
if (rclcpp::spin_until_future_complete(node, result) !=
rclcpp::FutureReturnCode::SUCCESS)
{
RCLCPP_INFO(rclcpp::get_logger("rclcpp"), "Sum: %ld", result.get()->sum);
Expand Down

3 comments on commit d1dc653

@ty-davis
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is literally wrong. Can we change this back? It worked when it was == and now it doesn't.

@christophebedard
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original PR was correct, but it should not have been backported. See #4934 (comment)

@christophebedard
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted in #4939

Please sign in to comment.