Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix a typo in Writing-A-Simple-Cpp-Service-And-Client.rst (backport #4934)" #4940

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Revert "Fix a typo in Writing-A-Simple-Cpp-Service-And-Client.rst (backport #4934)" #4940

merged 1 commit into from
Jan 14, 2025

Conversation

christophebedard
Copy link
Member

Reverts #4938

The code on Rolling is different from the code on other branches, so the condition has to be different. #4934 should not have been backported.

@christophebedard christophebedard mentioned this pull request Jan 14, 2025
Merged
@github-actions GitHub Actions
Copy link

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/12776898445/artifacts/2431121356.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-4940/index.html in your favorite browser

@christophebedard christophebedard merged commit cb928c7 into humble Jan 14, 2025
4 checks passed
@christophebedard christophebedard deleted the revert-4938-mergify/bp/humble/pr-4934 branch January 14, 2025 21:47
christophebedard referenced this pull request Jan 14, 2025
@mergify @jihyeseo @ahcorde
Fix a typo in Writing-A-Simple-Cpp-Service-And-Client.rst (backport #…
24c6ebf 
…4934) (#4938)

* Fix a typo in Writing-A-Simple-Cpp-Service-And-Client.rst (#4934)

Signed-off-by: Jihye Sofia Seo <[email protected]>
(cherry picked from commit 3959d21)

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Jihye Sofia Seo <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette Awaiting requested review from clalancette clalancette is a code owner

@audrow audrow Awaiting requested review from audrow audrow is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@christophebedard