Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/scroll mem reduction #274

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

fix: Rebase conflicts

0141b51
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

Feat/scroll mem reduction #274

fix: Rebase conflicts
0141b51
Select commit
Loading
Failed to load commit list.
GitHub Actions / Clippy (beta) succeeded Mar 2, 2024 in 1s

Clippy (beta)

67 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 67
Note 0
Help 0

Versions

  • rustc 1.73.0 (cc66ad468 2023-10-03)
  • cargo 1.73.0 (9c4383fb5 2023-08-26)
  • clippy 0.1.73 (cc66ad4 2023-10-03)

Annotations

Check warning on line 862 in halo2_backend/src/poly/domain.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

casting to the same type is unnecessary (`usize` -> `usize`)

warning: casting to the same type is unnecessary (`usize` -> `usize`)
   --> halo2_backend/src/poly/domain.rs:862:25
    |
862 |             poly.resize(domain.extended_len() as usize, Scalar::zero());
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `domain.extended_len()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 812 in halo2_backend/src/poly/domain.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

casting to the same type is unnecessary (`usize` -> `usize`)

warning: casting to the same type is unnecessary (`usize` -> `usize`)
   --> halo2_backend/src/poly/domain.rs:812:25
    |
812 |             poly.resize(domain.extended_len() as usize, Scalar::zero());
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `domain.extended_len()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 511 in halo2_backend/src/poly/domain.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

manual implementation of an assign operation

warning: manual implementation of an assign operation
   --> halo2_backend/src/poly/domain.rs:511:17
    |
511 |                 c_power = c_power * c;
    |                 ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `c_power *= c`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern

Check warning on line 508 in halo2_backend/src/poly/domain.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> halo2_backend/src/poly/domain.rs:508:45
    |
508 |             let mut c_power = c.pow_vartime(&[index as u64, 0, 0, 0]);
    |                                             ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[index as u64, 0, 0, 0]`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 399 in halo2_backend/src/poly/domain.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`

warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`
   --> halo2_backend/src/poly/domain.rs:399:73
    |
399 |             for (value, other) in values.iter_mut().zip(result[start..].into_iter()) {
    |                                                                         ^^^^^^^^^ help: call directly: `iter`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
    = note: `-W clippy::into-iter-on-ref` implied by `-W clippy::all`

Check warning on line 367 in halo2_backend/src/poly/domain.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

manual implementation of an assign operation

warning: manual implementation of an assign operation
   --> halo2_backend/src/poly/domain.rs:367:17
    |
367 |                 i = i << 1;
    |                 ^^^^^^^^^^ help: replace it with: `i <<= 1`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern

Check warning on line 177 in halo2_backend/src/poly/domain.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

casting to the same type is unnecessary (`usize` -> `usize`)

warning: casting to the same type is unnecessary (`usize` -> `usize`)
   --> halo2_backend/src/poly/domain.rs:177:34
    |
177 |         assert_eq!(values.len(), (self.extended_len() >> self.k) as usize);
    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `{ (self.extended_len() >> self.k) }`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
    = note: `-W clippy::unnecessary-cast` implied by `-W clippy::all`

Check warning on line 1230 in halo2_backend/src/plonk/evaluation.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

taken reference of right operand

warning: taken reference of right operand
    --> halo2_backend/src/plonk/evaluation.rs:1230:25
     |
1230 |                 &|a, b| a + &b,
     |                         ^^^^--
     |                             |
     |                             help: use the right value directly: `b`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref

Check warning on line 1166 in halo2_backend/src/plonk/evaluation.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

this function has too many arguments (13/7)

warning: this function has too many arguments (13/7)
    --> halo2_backend/src/plonk/evaluation.rs:1152:5
     |
1152 | /     pub fn evaluate<B: Basis>(
1153 | |         &self,
1154 | |         data: &mut EvaluationData<F>,
1155 | |         fixed: &[Option<Polynomial<F, B>>],
...    |
1165 | |         isize: i32,
1166 | |     ) -> F {
     | |__________^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 975 in halo2_backend/src/plonk/evaluation.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

manual implementation of an assign operation

warning: manual implementation of an assign operation
   --> halo2_backend/src/plonk/evaluation.rs:975:13
    |
975 |             idx = idx + 1;
    |             ^^^^^^^^^^^^^ help: replace it with: `idx += 1`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern

Check warning on line 961 in halo2_backend/src/plonk/evaluation.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

manual implementation of an assign operation

warning: manual implementation of an assign operation
   --> halo2_backend/src/plonk/evaluation.rs:961:33
    |
961 | ...                   *value = *value * y_power;
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value *= y_power`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern

Check warning on line 697 in halo2_backend/src/plonk/evaluation.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

manual implementation of an assign operation

warning: manual implementation of an assign operation
   --> halo2_backend/src/plonk/evaluation.rs:697:37
    |
697 | ...                   *value = *value * y_skip;
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value *= y_skip`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern

Check warning on line 692 in halo2_backend/src/plonk/evaluation.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> halo2_backend/src/plonk/evaluation.rs:692:57
    |
692 | ...                   * omega.pow_vartime(&[start as u64, 0, 0, 0]);
    |                                           ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[start as u64, 0, 0, 0]`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `-W clippy::needless-borrow` implied by `-W clippy::all`

Check warning on line 619 in halo2_backend/src/plonk/evaluation.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

manual implementation of an assign operation

warning: manual implementation of an assign operation
   --> halo2_backend/src/plonk/evaluation.rs:619:37
    |
619 | ...                   *value = *value * y_skip;
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value *= y_skip`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
    = note: `-W clippy::assign-op-pattern` implied by `-W clippy::all`

Check warning on line 547 in halo2_backend/src/plonk/evaluation.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

taken reference of right operand

warning: taken reference of right operand
   --> halo2_backend/src/plonk/evaluation.rs:547:39
    |
547 |                     let delta_start = beta * &C::Scalar::ZETA;
    |                                       ^^^^^^^----------------
    |                                              |
    |                                              help: use the right value directly: `C::Scalar::ZETA`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
    = note: `-W clippy::op-ref` implied by `-W clippy::all`

Check warning on line 407 in halo2_backend/src/plonk/evaluation.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

this function has too many arguments (11/7)

warning: this function has too many arguments (11/7)
   --> halo2_backend/src/plonk/evaluation.rs:395:5
    |
395 | /     pub(in crate::plonk) fn evaluate_h<C: CurveAffine<ScalarExt = F>>(
396 | |         &self,
397 | |         pk: &ProvingKey<C>,
398 | |         advice_polys: &[&[Polynomial<F, Coeff>]],
...   |
406 | |         permutations: &[permutation::prover::Committed<C>],
407 | |     ) -> Polynomial<F, ExtendedLagrangeCoeff> {
    | |_____________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 146 in halo2_backend/src/plonk/evaluation.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

this function has too many arguments (12/7)

warning: this function has too many arguments (12/7)
   --> halo2_backend/src/plonk/evaluation.rs:133:5
    |
133 | /     pub fn evaluate<F: Field, B: Basis>(
134 | |         &self,
135 | |         rotations: &[usize],
136 | |         constants: &[F],
...   |
145 | |         theta: &F,
146 | |     ) -> F {
    | |__________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 85 in halo2_backend/src/plonk/evaluation.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

this function has too many arguments (12/7)

warning: this function has too many arguments (12/7)
  --> halo2_backend/src/plonk/evaluation.rs:72:5
   |
72 | /     pub fn get<F: Field, B: Basis>(
73 | |         &self,
74 | |         rotations: &[usize],
75 | |         constants: &[F],
...  |
84 | |         theta: &F,
85 | |     ) -> F {
   | |__________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
   = note: `-W clippy::too-many-arguments` implied by `-W clippy::all`

Check warning on line 622 in halo2_proofs/tests/plonk_api.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

function `test_plonk_api_ipa` is never used

warning: function `test_plonk_api_ipa` is never used
   --> halo2_proofs/tests/plonk_api.rs:622:8
    |
622 |     fn test_plonk_api_ipa() {
    |        ^^^^^^^^^^^^^^^^^^

Check warning on line 592 in halo2_proofs/tests/plonk_api.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

type alias `Scheme` is never used

warning: type alias `Scheme` is never used
   --> halo2_proofs/tests/plonk_api.rs:592:14
    |
592 |         type Scheme = KZGCommitmentScheme<Bn256>;
    |              ^^^^^^

Check warning on line 556 in halo2_proofs/tests/plonk_api.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

type alias `Scheme` is never used

warning: type alias `Scheme` is never used
   --> halo2_proofs/tests/plonk_api.rs:556:14
    |
556 |         type Scheme = KZGCommitmentScheme<Bn256>;
    |              ^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

Check warning on line 16 in halo2_backend/src/plonk/evaluation.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused import: `PrimeField`

warning: unused import: `PrimeField`
  --> halo2_backend/src/plonk/evaluation.rs:16:30
   |
16 |     ff::{BatchInvert, Field, PrimeField, WithSmallOrderMulGroup},
   |                              ^^^^^^^^^^

Check warning on line 31 in halo2_backend/src/plonk/evaluation.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused import: `Index`

warning: unused import: `Index`
  --> halo2_backend/src/plonk/evaluation.rs:31:11
   |
31 |     ops::{Index, Mul, MulAssign},
   |           ^^^^^

Check warning on line 9 in halo2_backend/src/plonk/evaluation.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused import: `commitment::Params`

warning: unused import: `commitment::Params`
 --> halo2_backend/src/plonk/evaluation.rs:9:9
  |
9 |         commitment::Params, Coeff, EvaluationDomain, ExtendedLagrangeCoeff, LagrangeCoeff,
  |         ^^^^^^^^^^^^^^^^^^

Check warning on line 12 in halo2_backend/src/plonk/evaluation.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused import: `EncodedChallenge`

warning: unused import: `EncodedChallenge`
  --> halo2_backend/src/plonk/evaluation.rs:12:18
   |
12 |     transcript::{EncodedChallenge, TranscriptWrite},
   |                  ^^^^^^^^^^^^^^^^