Feat/scroll mem reduction #274
Clippy (1.56.1)
31 errors
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 31 |
Warning | 0 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.73.0 (cc66ad468 2023-10-03)
- cargo 1.73.0 (9c4383fb5 2023-08-26)
- clippy 0.1.73 (cc66ad4 2023-10-03)
Annotations
Check failure on line 511 in halo2_backend/src/poly/domain.rs
github-actions / Clippy (1.56.1)
manual implementation of an assign operation
error: manual implementation of an assign operation
--> halo2_backend/src/poly/domain.rs:511:17
|
511 | c_power = c_power * c;
| ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `c_power *= c`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
Check failure on line 508 in halo2_backend/src/poly/domain.rs
github-actions / Clippy (1.56.1)
the borrowed expression implements the required traits
error: the borrowed expression implements the required traits
--> halo2_backend/src/poly/domain.rs:508:45
|
508 | let mut c_power = c.pow_vartime(&[index as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[index as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check failure on line 399 in halo2_backend/src/poly/domain.rs
github-actions / Clippy (1.56.1)
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`
error: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`
--> halo2_backend/src/poly/domain.rs:399:73
|
399 | for (value, other) in values.iter_mut().zip(result[start..].into_iter()) {
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
= note: `-D clippy::into-iter-on-ref` implied by `-D warnings`
Check failure on line 367 in halo2_backend/src/poly/domain.rs
github-actions / Clippy (1.56.1)
manual implementation of an assign operation
error: manual implementation of an assign operation
--> halo2_backend/src/poly/domain.rs:367:17
|
367 | i = i << 1;
| ^^^^^^^^^^ help: replace it with: `i <<= 1`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
Check failure on line 177 in halo2_backend/src/poly/domain.rs
github-actions / Clippy (1.56.1)
casting to the same type is unnecessary (`usize` -> `usize`)
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_backend/src/poly/domain.rs:177:34
|
177 | assert_eq!(values.len(), (self.extended_len() >> self.k) as usize);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `{ (self.extended_len() >> self.k) }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `-D clippy::unnecessary-cast` implied by `-D warnings`
Check failure on line 1230 in halo2_backend/src/plonk/evaluation.rs
github-actions / Clippy (1.56.1)
taken reference of right operand
error: taken reference of right operand
--> halo2_backend/src/plonk/evaluation.rs:1230:25
|
1230 | &|a, b| a + &b,
| ^^^^--
| |
| help: use the right value directly: `b`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
Check failure on line 1166 in halo2_backend/src/plonk/evaluation.rs
github-actions / Clippy (1.56.1)
this function has too many arguments (13/7)
error: this function has too many arguments (13/7)
--> halo2_backend/src/plonk/evaluation.rs:1152:5
|
1152 | / pub fn evaluate<B: Basis>(
1153 | | &self,
1154 | | data: &mut EvaluationData<F>,
1155 | | fixed: &[Option<Polynomial<F, B>>],
... |
1165 | | isize: i32,
1166 | | ) -> F {
| |__________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
Check failure on line 975 in halo2_backend/src/plonk/evaluation.rs
github-actions / Clippy (1.56.1)
manual implementation of an assign operation
error: manual implementation of an assign operation
--> halo2_backend/src/plonk/evaluation.rs:975:13
|
975 | idx = idx + 1;
| ^^^^^^^^^^^^^ help: replace it with: `idx += 1`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
Check failure on line 961 in halo2_backend/src/plonk/evaluation.rs
github-actions / Clippy (1.56.1)
manual implementation of an assign operation
error: manual implementation of an assign operation
--> halo2_backend/src/plonk/evaluation.rs:961:33
|
961 | ... *value = *value * y_power;
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value *= y_power`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
Check failure on line 697 in halo2_backend/src/plonk/evaluation.rs
github-actions / Clippy (1.56.1)
manual implementation of an assign operation
error: manual implementation of an assign operation
--> halo2_backend/src/plonk/evaluation.rs:697:37
|
697 | ... *value = *value * y_skip;
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value *= y_skip`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
Check failure on line 692 in halo2_backend/src/plonk/evaluation.rs
github-actions / Clippy (1.56.1)
the borrowed expression implements the required traits
error: the borrowed expression implements the required traits
--> halo2_backend/src/plonk/evaluation.rs:692:57
|
692 | ... * omega.pow_vartime(&[start as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[start as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
Check failure on line 619 in halo2_backend/src/plonk/evaluation.rs
github-actions / Clippy (1.56.1)
manual implementation of an assign operation
error: manual implementation of an assign operation
--> halo2_backend/src/plonk/evaluation.rs:619:37
|
619 | ... *value = *value * y_skip;
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value *= y_skip`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
= note: `-D clippy::assign-op-pattern` implied by `-D warnings`
Check failure on line 547 in halo2_backend/src/plonk/evaluation.rs
github-actions / Clippy (1.56.1)
taken reference of right operand
error: taken reference of right operand
--> halo2_backend/src/plonk/evaluation.rs:547:39
|
547 | let delta_start = beta * &C::Scalar::ZETA;
| ^^^^^^^----------------
| |
| help: use the right value directly: `C::Scalar::ZETA`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
= note: `-D clippy::op-ref` implied by `-D warnings`
Check failure on line 407 in halo2_backend/src/plonk/evaluation.rs
github-actions / Clippy (1.56.1)
this function has too many arguments (11/7)
error: this function has too many arguments (11/7)
--> halo2_backend/src/plonk/evaluation.rs:395:5
|
395 | / pub(in crate::plonk) fn evaluate_h<C: CurveAffine<ScalarExt = F>>(
396 | | &self,
397 | | pk: &ProvingKey<C>,
398 | | advice_polys: &[&[Polynomial<F, Coeff>]],
... |
406 | | permutations: &[permutation::prover::Committed<C>],
407 | | ) -> Polynomial<F, ExtendedLagrangeCoeff> {
| |_____________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
Check failure on line 146 in halo2_backend/src/plonk/evaluation.rs
github-actions / Clippy (1.56.1)
this function has too many arguments (12/7)
error: this function has too many arguments (12/7)
--> halo2_backend/src/plonk/evaluation.rs:133:5
|
133 | / pub fn evaluate<F: Field, B: Basis>(
134 | | &self,
135 | | rotations: &[usize],
136 | | constants: &[F],
... |
145 | | theta: &F,
146 | | ) -> F {
| |__________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
Check failure on line 85 in halo2_backend/src/plonk/evaluation.rs
github-actions / Clippy (1.56.1)
this function has too many arguments (12/7)
error: this function has too many arguments (12/7)
--> halo2_backend/src/plonk/evaluation.rs:72:5
|
72 | / pub fn get<F: Field, B: Basis>(
73 | | &self,
74 | | rotations: &[usize],
75 | | constants: &[F],
... |
84 | | theta: &F,
85 | | ) -> F {
| |__________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `-D clippy::too-many-arguments` implied by `-D warnings`
Check failure on line 16 in halo2_backend/src/plonk/evaluation.rs
github-actions / Clippy (1.56.1)
unused import: `PrimeField`
error: unused import: `PrimeField`
--> halo2_backend/src/plonk/evaluation.rs:16:30
|
16 | ff::{BatchInvert, Field, PrimeField, WithSmallOrderMulGroup},
| ^^^^^^^^^^
Check failure on line 31 in halo2_backend/src/plonk/evaluation.rs
github-actions / Clippy (1.56.1)
unused import: `Index`
error: unused import: `Index`
--> halo2_backend/src/plonk/evaluation.rs:31:11
|
31 | ops::{Index, Mul, MulAssign},
| ^^^^^
Check failure on line 9 in halo2_backend/src/plonk/evaluation.rs
github-actions / Clippy (1.56.1)
unused import: `commitment::Params`
error: unused import: `commitment::Params`
--> halo2_backend/src/plonk/evaluation.rs:9:9
|
9 | commitment::Params, Coeff, EvaluationDomain, ExtendedLagrangeCoeff, LagrangeCoeff,
| ^^^^^^^^^^^^^^^^^^
Check failure on line 12 in halo2_backend/src/plonk/evaluation.rs
github-actions / Clippy (1.56.1)
unused import: `EncodedChallenge`
error: unused import: `EncodedChallenge`
--> halo2_backend/src/plonk/evaluation.rs:12:18
|
12 | transcript::{EncodedChallenge, TranscriptWrite},
| ^^^^^^^^^^^^^^^^
Check failure on line 29 in halo2_backend/src/plonk/evaluation.rs
github-actions / Clippy (1.56.1)
unused imports: `MulAssign`, `Mul`, `collections::BTreeMap`, `iter`
error: unused imports: `MulAssign`, `Mul`, `collections::BTreeMap`, `iter`
--> halo2_backend/src/plonk/evaluation.rs:29:5
|
29 | collections::BTreeMap,
| ^^^^^^^^^^^^^^^^^^^^^
30 | iter,
| ^^^^
31 | ops::{Index, Mul, MulAssign},
| ^^^ ^^^^^^^^^
Check failure on line 27 in halo2_backend/src/plonk/evaluation.rs
github-actions / Clippy (1.56.1)
unused import: `std::time::Instant`
error: unused import: `std::time::Instant`
--> halo2_backend/src/plonk/evaluation.rs:27:5
|
27 | use std::time::Instant;
| ^^^^^^^^^^^^^^^^^^
Check failure on line 26 in halo2_backend/src/plonk/evaluation.rs
github-actions / Clippy (1.56.1)
unused import: `std::slice`
error: unused import: `std::slice`
--> halo2_backend/src/plonk/evaluation.rs:26:5
|
26 | use std::slice;
| ^^^^^^^^^^
Check failure on line 25 in halo2_backend/src/plonk/evaluation.rs
github-actions / Clippy (1.56.1)
unused import: `std::num::ParseIntError`
error: unused import: `std::num::ParseIntError`
--> halo2_backend/src/plonk/evaluation.rs:25:5
|
25 | use std::num::ParseIntError;
| ^^^^^^^^^^^^^^^^^^^^^^^
Check failure on line 24 in halo2_backend/src/plonk/evaluation.rs
github-actions / Clippy (1.56.1)
unused import: `std::convert::TryInto`
error: unused import: `std::convert::TryInto`
--> halo2_backend/src/plonk/evaluation.rs:24:5
|
24 | use std::convert::TryInto;
| ^^^^^^^^^^^^^^^^^^^^^