Skip to content

fix: Rebase conflicts #372

fix: Rebase conflicts

fix: Rebase conflicts #372

Triggered via push March 2, 2024 20:05
Status Success
Total duration 1m 9s
Artifacts

lints-beta.yml

on: push
Clippy (beta)
1m 1s
Clippy (beta)
Fit to window
Zoom out
Zoom in

Annotations

31 errors and 73 warnings
manual implementation of an assign operation: halo2_backend/src/poly/domain.rs#L511
error: manual implementation of an assign operation --> halo2_backend/src/poly/domain.rs:511:17 | 511 | c_power = c_power * c; | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `c_power *= c` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
the borrowed expression implements the required traits: halo2_backend/src/poly/domain.rs#L508
error: the borrowed expression implements the required traits --> halo2_backend/src/poly/domain.rs:508:45 | 508 | let mut c_power = c.pow_vartime(&[index as u64, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[index as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`: halo2_backend/src/poly/domain.rs#L399
error: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` --> halo2_backend/src/poly/domain.rs:399:73 | 399 | for (value, other) in values.iter_mut().zip(result[start..].into_iter()) { | ^^^^^^^^^ help: call directly: `iter` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref = note: `-D clippy::into-iter-on-ref` implied by `-D warnings`
manual implementation of an assign operation: halo2_backend/src/poly/domain.rs#L367
error: manual implementation of an assign operation --> halo2_backend/src/poly/domain.rs:367:17 | 367 | i = i << 1; | ^^^^^^^^^^ help: replace it with: `i <<= 1` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
casting to the same type is unnecessary (`usize` -> `usize`): halo2_backend/src/poly/domain.rs#L177
error: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_backend/src/poly/domain.rs:177:34 | 177 | assert_eq!(values.len(), (self.extended_len() >> self.k) as usize); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `{ (self.extended_len() >> self.k) }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `-D clippy::unnecessary-cast` implied by `-D warnings`
taken reference of right operand: halo2_backend/src/plonk/evaluation.rs#L1230
error: taken reference of right operand --> halo2_backend/src/plonk/evaluation.rs:1230:25 | 1230 | &|a, b| a + &b, | ^^^^-- | | | help: use the right value directly: `b` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
this function has too many arguments (13/7): halo2_backend/src/plonk/evaluation.rs#L1152
error: this function has too many arguments (13/7) --> halo2_backend/src/plonk/evaluation.rs:1152:5 | 1152 | / pub fn evaluate<B: Basis>( 1153 | | &self, 1154 | | data: &mut EvaluationData<F>, 1155 | | fixed: &[Option<Polynomial<F, B>>], ... | 1165 | | isize: i32, 1166 | | ) -> F { | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
manual implementation of an assign operation: halo2_backend/src/plonk/evaluation.rs#L975
error: manual implementation of an assign operation --> halo2_backend/src/plonk/evaluation.rs:975:13 | 975 | idx = idx + 1; | ^^^^^^^^^^^^^ help: replace it with: `idx += 1` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
manual implementation of an assign operation: halo2_backend/src/plonk/evaluation.rs#L961
error: manual implementation of an assign operation --> halo2_backend/src/plonk/evaluation.rs:961:33 | 961 | ... *value = *value * y_power; | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value *= y_power` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
manual implementation of an assign operation: halo2_backend/src/plonk/evaluation.rs#L697
error: manual implementation of an assign operation --> halo2_backend/src/plonk/evaluation.rs:697:37 | 697 | ... *value = *value * y_skip; | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value *= y_skip` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
the borrowed expression implements the required traits: halo2_backend/src/plonk/evaluation.rs#L692
error: the borrowed expression implements the required traits --> halo2_backend/src/plonk/evaluation.rs:692:57 | 692 | ... * omega.pow_vartime(&[start as u64, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[start as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings`
manual implementation of an assign operation: halo2_backend/src/plonk/evaluation.rs#L619
error: manual implementation of an assign operation --> halo2_backend/src/plonk/evaluation.rs:619:37 | 619 | ... *value = *value * y_skip; | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value *= y_skip` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern = note: `-D clippy::assign-op-pattern` implied by `-D warnings`
taken reference of right operand: halo2_backend/src/plonk/evaluation.rs#L547
error: taken reference of right operand --> halo2_backend/src/plonk/evaluation.rs:547:39 | 547 | let delta_start = beta * &C::Scalar::ZETA; | ^^^^^^^---------------- | | | help: use the right value directly: `C::Scalar::ZETA` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `-D clippy::op-ref` implied by `-D warnings`
this function has too many arguments (11/7): halo2_backend/src/plonk/evaluation.rs#L395
error: this function has too many arguments (11/7) --> halo2_backend/src/plonk/evaluation.rs:395:5 | 395 | / pub(in crate::plonk) fn evaluate_h<C: CurveAffine<ScalarExt = F>>( 396 | | &self, 397 | | pk: &ProvingKey<C>, 398 | | advice_polys: &[&[Polynomial<F, Coeff>]], ... | 406 | | permutations: &[permutation::prover::Committed<C>], 407 | | ) -> Polynomial<F, ExtendedLagrangeCoeff> { | |_____________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (12/7): halo2_backend/src/plonk/evaluation.rs#L133
error: this function has too many arguments (12/7) --> halo2_backend/src/plonk/evaluation.rs:133:5 | 133 | / pub fn evaluate<F: Field, B: Basis>( 134 | | &self, 135 | | rotations: &[usize], 136 | | constants: &[F], ... | 145 | | theta: &F, 146 | | ) -> F { | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (12/7): halo2_backend/src/plonk/evaluation.rs#L72
error: this function has too many arguments (12/7) --> halo2_backend/src/plonk/evaluation.rs:72:5 | 72 | / pub fn get<F: Field, B: Basis>( 73 | | &self, 74 | | rotations: &[usize], 75 | | constants: &[F], ... | 84 | | theta: &F, 85 | | ) -> F { | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `-D clippy::too-many-arguments` implied by `-D warnings`
unused import: `PrimeField`: halo2_backend/src/plonk/evaluation.rs#L16
error: unused import: `PrimeField` --> halo2_backend/src/plonk/evaluation.rs:16:30 | 16 | ff::{BatchInvert, Field, PrimeField, WithSmallOrderMulGroup}, | ^^^^^^^^^^
unused import: `Index`: halo2_backend/src/plonk/evaluation.rs#L31
error: unused import: `Index` --> halo2_backend/src/plonk/evaluation.rs:31:11 | 31 | ops::{Index, Mul, MulAssign}, | ^^^^^
unused import: `commitment::Params`: halo2_backend/src/plonk/evaluation.rs#L9
error: unused import: `commitment::Params` --> halo2_backend/src/plonk/evaluation.rs:9:9 | 9 | commitment::Params, Coeff, EvaluationDomain, ExtendedLagrangeCoeff, LagrangeCoeff, | ^^^^^^^^^^^^^^^^^^
unused import: `EncodedChallenge`: halo2_backend/src/plonk/evaluation.rs#L12
error: unused import: `EncodedChallenge` --> halo2_backend/src/plonk/evaluation.rs:12:18 | 12 | transcript::{EncodedChallenge, TranscriptWrite}, | ^^^^^^^^^^^^^^^^
unused imports: `MulAssign`, `Mul`, `collections::BTreeMap`, `iter`: halo2_backend/src/plonk/evaluation.rs#L29
error: unused imports: `MulAssign`, `Mul`, `collections::BTreeMap`, `iter` --> halo2_backend/src/plonk/evaluation.rs:29:5 | 29 | collections::BTreeMap, | ^^^^^^^^^^^^^^^^^^^^^ 30 | iter, | ^^^^ 31 | ops::{Index, Mul, MulAssign}, | ^^^ ^^^^^^^^^
unused import: `std::time::Instant`: halo2_backend/src/plonk/evaluation.rs#L27
error: unused import: `std::time::Instant` --> halo2_backend/src/plonk/evaluation.rs:27:5 | 27 | use std::time::Instant; | ^^^^^^^^^^^^^^^^^^
unused import: `std::slice`: halo2_backend/src/plonk/evaluation.rs#L26
error: unused import: `std::slice` --> halo2_backend/src/plonk/evaluation.rs:26:5 | 26 | use std::slice; | ^^^^^^^^^^
unused import: `std::num::ParseIntError`: halo2_backend/src/plonk/evaluation.rs#L25
error: unused import: `std::num::ParseIntError` --> halo2_backend/src/plonk/evaluation.rs:25:5 | 25 | use std::num::ParseIntError; | ^^^^^^^^^^^^^^^^^^^^^^^
unused import: `std::convert::TryInto`: halo2_backend/src/plonk/evaluation.rs#L24
error: unused import: `std::convert::TryInto` --> halo2_backend/src/plonk/evaluation.rs:24:5 | 24 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^
unused import: `std::any::TypeId`: halo2_backend/src/plonk/evaluation.rs#L23
error: unused import: `std::any::TypeId` --> halo2_backend/src/plonk/evaluation.rs:23:5 | 23 | use std::any::TypeId; | ^^^^^^^^^^^^^^^^
unused imports: `BatchInvert`, `Curve`: halo2_backend/src/plonk/evaluation.rs#L16
error: unused imports: `BatchInvert`, `Curve` --> halo2_backend/src/plonk/evaluation.rs:16:10 | 16 | ff::{BatchInvert, Field, PrimeField, WithSmallOrderMulGroup}, | ^^^^^^^^^^^ 17 | Curve, | ^^^^^
unused import: `group::prime::PrimeCurve`: halo2_backend/src/plonk/evaluation.rs#L14
error: unused import: `group::prime::PrimeCurve` --> halo2_backend/src/plonk/evaluation.rs:14:5 | 14 | use group::prime::PrimeCurve; | ^^^^^^^^^^^^^^^^^^^^^^^^
unused imports: `EvaluationDomain`, `ProverQuery`, `TranscriptWrite`, `eval_polynomial`: halo2_backend/src/plonk/evaluation.rs#L7
error: unused imports: `EvaluationDomain`, `ProverQuery`, `TranscriptWrite`, `eval_polynomial` --> halo2_backend/src/plonk/evaluation.rs:7:18 | 7 | arithmetic::{eval_polynomial, parallelize, CurveAffine}, | ^^^^^^^^^^^^^^^ 8 | poly::{ 9 | commitment::Params, Coeff, EvaluationDomain, ExtendedLagrangeCoeff, LagrangeCoeff, | ^^^^^^^^^^^^^^^^ 10 | Polynomial, ProverQuery, | ^^^^^^^^^^^ 11 | }, 12 | transcript::{EncodedChallenge, TranscriptWrite}, | ^^^^^^^^^^^^^^^
unused import: `crate::plonk::permutation::Argument`: halo2_backend/src/plonk/evaluation.rs#L3
error: unused import: `crate::plonk::permutation::Argument` --> halo2_backend/src/plonk/evaluation.rs:3:5 | 3 | use crate::plonk::permutation::Argument; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `crate::plonk::lookup::prover::Committed`: halo2_backend/src/plonk/evaluation.rs#L2
error: unused import: `crate::plonk::lookup::prover::Committed` --> halo2_backend/src/plonk/evaluation.rs:2:5 | 2 | use crate::plonk::lookup::prover::Committed; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `-D unused-imports` implied by `-D warnings`
casting to the same type is unnecessary (`usize` -> `usize`): halo2_backend/src/poly/domain.rs#L862
warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_backend/src/poly/domain.rs:862:25 | 862 | poly.resize(domain.extended_len() as usize, Scalar::zero()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `domain.extended_len()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
casting to the same type is unnecessary (`usize` -> `usize`): halo2_backend/src/poly/domain.rs#L812
warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_backend/src/poly/domain.rs:812:25 | 812 | poly.resize(domain.extended_len() as usize, Scalar::zero()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `domain.extended_len()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
manual implementation of an assign operation: halo2_backend/src/poly/domain.rs#L511
warning: manual implementation of an assign operation --> halo2_backend/src/poly/domain.rs:511:17 | 511 | c_power = c_power * c; | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `c_power *= c` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
the borrowed expression implements the required traits: halo2_backend/src/poly/domain.rs#L508
warning: the borrowed expression implements the required traits --> halo2_backend/src/poly/domain.rs:508:45 | 508 | let mut c_power = c.pow_vartime(&[index as u64, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[index as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`: halo2_backend/src/poly/domain.rs#L399
warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` --> halo2_backend/src/poly/domain.rs:399:73 | 399 | for (value, other) in values.iter_mut().zip(result[start..].into_iter()) { | ^^^^^^^^^ help: call directly: `iter` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref = note: `-W clippy::into-iter-on-ref` implied by `-W clippy::all`
manual implementation of an assign operation: halo2_backend/src/poly/domain.rs#L367
warning: manual implementation of an assign operation --> halo2_backend/src/poly/domain.rs:367:17 | 367 | i = i << 1; | ^^^^^^^^^^ help: replace it with: `i <<= 1` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
casting to the same type is unnecessary (`usize` -> `usize`): halo2_backend/src/poly/domain.rs#L177
warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_backend/src/poly/domain.rs:177:34 | 177 | assert_eq!(values.len(), (self.extended_len() >> self.k) as usize); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `{ (self.extended_len() >> self.k) }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `-W clippy::unnecessary-cast` implied by `-W clippy::all`
taken reference of right operand: halo2_backend/src/plonk/evaluation.rs#L1230
warning: taken reference of right operand --> halo2_backend/src/plonk/evaluation.rs:1230:25 | 1230 | &|a, b| a + &b, | ^^^^-- | | | help: use the right value directly: `b` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
this function has too many arguments (13/7): halo2_backend/src/plonk/evaluation.rs#L1152
warning: this function has too many arguments (13/7) --> halo2_backend/src/plonk/evaluation.rs:1152:5 | 1152 | / pub fn evaluate<B: Basis>( 1153 | | &self, 1154 | | data: &mut EvaluationData<F>, 1155 | | fixed: &[Option<Polynomial<F, B>>], ... | 1165 | | isize: i32, 1166 | | ) -> F { | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
manual implementation of an assign operation: halo2_backend/src/plonk/evaluation.rs#L975
warning: manual implementation of an assign operation --> halo2_backend/src/plonk/evaluation.rs:975:13 | 975 | idx = idx + 1; | ^^^^^^^^^^^^^ help: replace it with: `idx += 1` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
manual implementation of an assign operation: halo2_backend/src/plonk/evaluation.rs#L961
warning: manual implementation of an assign operation --> halo2_backend/src/plonk/evaluation.rs:961:33 | 961 | ... *value = *value * y_power; | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value *= y_power` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
manual implementation of an assign operation: halo2_backend/src/plonk/evaluation.rs#L697
warning: manual implementation of an assign operation --> halo2_backend/src/plonk/evaluation.rs:697:37 | 697 | ... *value = *value * y_skip; | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value *= y_skip` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
the borrowed expression implements the required traits: halo2_backend/src/plonk/evaluation.rs#L692
warning: the borrowed expression implements the required traits --> halo2_backend/src/plonk/evaluation.rs:692:57 | 692 | ... * omega.pow_vartime(&[start as u64, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[start as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all`
manual implementation of an assign operation: halo2_backend/src/plonk/evaluation.rs#L619
warning: manual implementation of an assign operation --> halo2_backend/src/plonk/evaluation.rs:619:37 | 619 | ... *value = *value * y_skip; | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value *= y_skip` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern = note: `-W clippy::assign-op-pattern` implied by `-W clippy::all`
taken reference of right operand: halo2_backend/src/plonk/evaluation.rs#L547
warning: taken reference of right operand --> halo2_backend/src/plonk/evaluation.rs:547:39 | 547 | let delta_start = beta * &C::Scalar::ZETA; | ^^^^^^^---------------- | | | help: use the right value directly: `C::Scalar::ZETA` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `-W clippy::op-ref` implied by `-W clippy::all`
this function has too many arguments (11/7): halo2_backend/src/plonk/evaluation.rs#L395
warning: this function has too many arguments (11/7) --> halo2_backend/src/plonk/evaluation.rs:395:5 | 395 | / pub(in crate::plonk) fn evaluate_h<C: CurveAffine<ScalarExt = F>>( 396 | | &self, 397 | | pk: &ProvingKey<C>, 398 | | advice_polys: &[&[Polynomial<F, Coeff>]], ... | 406 | | permutations: &[permutation::prover::Committed<C>], 407 | | ) -> Polynomial<F, ExtendedLagrangeCoeff> { | |_____________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (12/7): halo2_backend/src/plonk/evaluation.rs#L133
warning: this function has too many arguments (12/7) --> halo2_backend/src/plonk/evaluation.rs:133:5 | 133 | / pub fn evaluate<F: Field, B: Basis>( 134 | | &self, 135 | | rotations: &[usize], 136 | | constants: &[F], ... | 145 | | theta: &F, 146 | | ) -> F { | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (12/7): halo2_backend/src/plonk/evaluation.rs#L72
warning: this function has too many arguments (12/7) --> halo2_backend/src/plonk/evaluation.rs:72:5 | 72 | / pub fn get<F: Field, B: Basis>( 73 | | &self, 74 | | rotations: &[usize], 75 | | constants: &[F], ... | 84 | | theta: &F, 85 | | ) -> F { | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `-W clippy::too-many-arguments` implied by `-W clippy::all`
function `test_plonk_api_ipa` is never used: halo2_proofs/tests/plonk_api.rs#L622
warning: function `test_plonk_api_ipa` is never used --> halo2_proofs/tests/plonk_api.rs:622:8 | 622 | fn test_plonk_api_ipa() { | ^^^^^^^^^^^^^^^^^^
type alias `Scheme` is never used: halo2_proofs/tests/plonk_api.rs#L592
warning: type alias `Scheme` is never used --> halo2_proofs/tests/plonk_api.rs:592:14 | 592 | type Scheme = KZGCommitmentScheme<Bn256>; | ^^^^^^
type alias `Scheme` is never used: halo2_proofs/tests/plonk_api.rs#L556
warning: type alias `Scheme` is never used --> halo2_proofs/tests/plonk_api.rs:556:14 | 556 | type Scheme = KZGCommitmentScheme<Bn256>; | ^^^^^^ | = note: `#[warn(dead_code)]` on by default
unused import: `PrimeField`: halo2_backend/src/plonk/evaluation.rs#L16
warning: unused import: `PrimeField` --> halo2_backend/src/plonk/evaluation.rs:16:30 | 16 | ff::{BatchInvert, Field, PrimeField, WithSmallOrderMulGroup}, | ^^^^^^^^^^
unused import: `Index`: halo2_backend/src/plonk/evaluation.rs#L31
warning: unused import: `Index` --> halo2_backend/src/plonk/evaluation.rs:31:11 | 31 | ops::{Index, Mul, MulAssign}, | ^^^^^
unused import: `commitment::Params`: halo2_backend/src/plonk/evaluation.rs#L9
warning: unused import: `commitment::Params` --> halo2_backend/src/plonk/evaluation.rs:9:9 | 9 | commitment::Params, Coeff, EvaluationDomain, ExtendedLagrangeCoeff, LagrangeCoeff, | ^^^^^^^^^^^^^^^^^^
unused import: `EncodedChallenge`: halo2_backend/src/plonk/evaluation.rs#L12
warning: unused import: `EncodedChallenge` --> halo2_backend/src/plonk/evaluation.rs:12:18 | 12 | transcript::{EncodedChallenge, TranscriptWrite}, | ^^^^^^^^^^^^^^^^
unused imports: `MulAssign`, `Mul`, `collections::BTreeMap`, `iter`: halo2_backend/src/plonk/evaluation.rs#L29
warning: unused imports: `MulAssign`, `Mul`, `collections::BTreeMap`, `iter` --> halo2_backend/src/plonk/evaluation.rs:29:5 | 29 | collections::BTreeMap, | ^^^^^^^^^^^^^^^^^^^^^ 30 | iter, | ^^^^ 31 | ops::{Index, Mul, MulAssign}, | ^^^ ^^^^^^^^^
unused import: `std::time::Instant`: halo2_backend/src/plonk/evaluation.rs#L27
warning: unused import: `std::time::Instant` --> halo2_backend/src/plonk/evaluation.rs:27:5 | 27 | use std::time::Instant; | ^^^^^^^^^^^^^^^^^^
unused import: `std::slice`: halo2_backend/src/plonk/evaluation.rs#L26
warning: unused import: `std::slice` --> halo2_backend/src/plonk/evaluation.rs:26:5 | 26 | use std::slice; | ^^^^^^^^^^
unused import: `std::num::ParseIntError`: halo2_backend/src/plonk/evaluation.rs#L25
warning: unused import: `std::num::ParseIntError` --> halo2_backend/src/plonk/evaluation.rs:25:5 | 25 | use std::num::ParseIntError; | ^^^^^^^^^^^^^^^^^^^^^^^
unused import: `std::convert::TryInto`: halo2_backend/src/plonk/evaluation.rs#L24
warning: unused import: `std::convert::TryInto` --> halo2_backend/src/plonk/evaluation.rs:24:5 | 24 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^
unused import: `std::any::TypeId`: halo2_backend/src/plonk/evaluation.rs#L23
warning: unused import: `std::any::TypeId` --> halo2_backend/src/plonk/evaluation.rs:23:5 | 23 | use std::any::TypeId; | ^^^^^^^^^^^^^^^^
unused imports: `BatchInvert`, `Curve`: halo2_backend/src/plonk/evaluation.rs#L16
warning: unused imports: `BatchInvert`, `Curve` --> halo2_backend/src/plonk/evaluation.rs:16:10 | 16 | ff::{BatchInvert, Field, PrimeField, WithSmallOrderMulGroup}, | ^^^^^^^^^^^ 17 | Curve, | ^^^^^
unused import: `group::prime::PrimeCurve`: halo2_backend/src/plonk/evaluation.rs#L14
warning: unused import: `group::prime::PrimeCurve` --> halo2_backend/src/plonk/evaluation.rs:14:5 | 14 | use group::prime::PrimeCurve; | ^^^^^^^^^^^^^^^^^^^^^^^^
unused imports: `EvaluationDomain`, `ProverQuery`, `TranscriptWrite`, `eval_polynomial`: halo2_backend/src/plonk/evaluation.rs#L7
warning: unused imports: `EvaluationDomain`, `ProverQuery`, `TranscriptWrite`, `eval_polynomial` --> halo2_backend/src/plonk/evaluation.rs:7:18 | 7 | arithmetic::{eval_polynomial, parallelize, CurveAffine}, | ^^^^^^^^^^^^^^^ 8 | poly::{ 9 | commitment::Params, Coeff, EvaluationDomain, ExtendedLagrangeCoeff, LagrangeCoeff, | ^^^^^^^^^^^^^^^^ 10 | Polynomial, ProverQuery, | ^^^^^^^^^^^ 11 | }, 12 | transcript::{EncodedChallenge, TranscriptWrite}, | ^^^^^^^^^^^^^^^
unused import: `crate::plonk::permutation::Argument`: halo2_backend/src/plonk/evaluation.rs#L3
warning: unused import: `crate::plonk::permutation::Argument` --> halo2_backend/src/plonk/evaluation.rs:3:5 | 3 | use crate::plonk::permutation::Argument; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `crate::plonk::lookup::prover::Committed`: halo2_backend/src/plonk/evaluation.rs#L2
warning: unused import: `crate::plonk::lookup::prover::Committed` --> halo2_backend/src/plonk/evaluation.rs:2:5 | 2 | use crate::plonk::lookup::prover::Committed; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
manual implementation of an assign operation: halo2_backend/src/poly/domain.rs#L511
warning: manual implementation of an assign operation --> halo2_backend/src/poly/domain.rs:511:17 | 511 | c_power = c_power * c; | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `c_power *= c` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
the borrowed expression implements the required traits: halo2_backend/src/poly/domain.rs#L508
warning: the borrowed expression implements the required traits --> halo2_backend/src/poly/domain.rs:508:45 | 508 | let mut c_power = c.pow_vartime(&[index as u64, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[index as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`: halo2_backend/src/poly/domain.rs#L399
warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` --> halo2_backend/src/poly/domain.rs:399:73 | 399 | for (value, other) in values.iter_mut().zip(result[start..].into_iter()) { | ^^^^^^^^^ help: call directly: `iter` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref = note: `-W clippy::into-iter-on-ref` implied by `-W clippy::all`
manual implementation of an assign operation: halo2_backend/src/poly/domain.rs#L367
warning: manual implementation of an assign operation --> halo2_backend/src/poly/domain.rs:367:17 | 367 | i = i << 1; | ^^^^^^^^^^ help: replace it with: `i <<= 1` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
casting to the same type is unnecessary (`usize` -> `usize`): halo2_backend/src/poly/domain.rs#L177
warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_backend/src/poly/domain.rs:177:34 | 177 | assert_eq!(values.len(), (self.extended_len() >> self.k) as usize); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `{ (self.extended_len() >> self.k) }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `-W clippy::unnecessary-cast` implied by `-W clippy::all`
taken reference of right operand: halo2_backend/src/plonk/evaluation.rs#L1230
warning: taken reference of right operand --> halo2_backend/src/plonk/evaluation.rs:1230:25 | 1230 | &|a, b| a + &b, | ^^^^-- | | | help: use the right value directly: `b` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
this function has too many arguments (13/7): halo2_backend/src/plonk/evaluation.rs#L1152
warning: this function has too many arguments (13/7) --> halo2_backend/src/plonk/evaluation.rs:1152:5 | 1152 | / pub fn evaluate<B: Basis>( 1153 | | &self, 1154 | | data: &mut EvaluationData<F>, 1155 | | fixed: &[Option<Polynomial<F, B>>], ... | 1165 | | isize: i32, 1166 | | ) -> F { | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
manual implementation of an assign operation: halo2_backend/src/plonk/evaluation.rs#L975
warning: manual implementation of an assign operation --> halo2_backend/src/plonk/evaluation.rs:975:13 | 975 | idx = idx + 1; | ^^^^^^^^^^^^^ help: replace it with: `idx += 1` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
manual implementation of an assign operation: halo2_backend/src/plonk/evaluation.rs#L961
warning: manual implementation of an assign operation --> halo2_backend/src/plonk/evaluation.rs:961:33 | 961 | ... *value = *value * y_power; | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value *= y_power` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
manual implementation of an assign operation: halo2_backend/src/plonk/evaluation.rs#L697
warning: manual implementation of an assign operation --> halo2_backend/src/plonk/evaluation.rs:697:37 | 697 | ... *value = *value * y_skip; | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value *= y_skip` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
the borrowed expression implements the required traits: halo2_backend/src/plonk/evaluation.rs#L692
warning: the borrowed expression implements the required traits --> halo2_backend/src/plonk/evaluation.rs:692:57 | 692 | ... * omega.pow_vartime(&[start as u64, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[start as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all`
manual implementation of an assign operation: halo2_backend/src/plonk/evaluation.rs#L619
warning: manual implementation of an assign operation --> halo2_backend/src/plonk/evaluation.rs:619:37 | 619 | ... *value = *value * y_skip; | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value *= y_skip` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern = note: `-W clippy::assign-op-pattern` implied by `-W clippy::all`
taken reference of right operand: halo2_backend/src/plonk/evaluation.rs#L547
warning: taken reference of right operand --> halo2_backend/src/plonk/evaluation.rs:547:39 | 547 | let delta_start = beta * &C::Scalar::ZETA; | ^^^^^^^---------------- | | | help: use the right value directly: `C::Scalar::ZETA` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `-W clippy::op-ref` implied by `-W clippy::all`
this function has too many arguments (11/7): halo2_backend/src/plonk/evaluation.rs#L395
warning: this function has too many arguments (11/7) --> halo2_backend/src/plonk/evaluation.rs:395:5 | 395 | / pub(in crate::plonk) fn evaluate_h<C: CurveAffine<ScalarExt = F>>( 396 | | &self, 397 | | pk: &ProvingKey<C>, 398 | | advice_polys: &[&[Polynomial<F, Coeff>]], ... | 406 | | permutations: &[permutation::prover::Committed<C>], 407 | | ) -> Polynomial<F, ExtendedLagrangeCoeff> { | |_____________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (12/7): halo2_backend/src/plonk/evaluation.rs#L133
warning: this function has too many arguments (12/7) --> halo2_backend/src/plonk/evaluation.rs:133:5 | 133 | / pub fn evaluate<F: Field, B: Basis>( 134 | | &self, 135 | | rotations: &[usize], 136 | | constants: &[F], ... | 145 | | theta: &F, 146 | | ) -> F { | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (12/7): halo2_backend/src/plonk/evaluation.rs#L72
warning: this function has too many arguments (12/7) --> halo2_backend/src/plonk/evaluation.rs:72:5 | 72 | / pub fn get<F: Field, B: Basis>( 73 | | &self, 74 | | rotations: &[usize], 75 | | constants: &[F], ... | 84 | | theta: &F, 85 | | ) -> F { | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `-W clippy::too-many-arguments` implied by `-W clippy::all`
unused import: `PrimeField`: halo2_backend/src/plonk/evaluation.rs#L16
warning: unused import: `PrimeField` --> halo2_backend/src/plonk/evaluation.rs:16:30 | 16 | ff::{BatchInvert, Field, PrimeField, WithSmallOrderMulGroup}, | ^^^^^^^^^^
unused import: `Index`: halo2_backend/src/plonk/evaluation.rs#L31
warning: unused import: `Index` --> halo2_backend/src/plonk/evaluation.rs:31:11 | 31 | ops::{Index, Mul, MulAssign}, | ^^^^^
unused import: `commitment::Params`: halo2_backend/src/plonk/evaluation.rs#L9
warning: unused import: `commitment::Params` --> halo2_backend/src/plonk/evaluation.rs:9:9 | 9 | commitment::Params, Coeff, EvaluationDomain, ExtendedLagrangeCoeff, LagrangeCoeff, | ^^^^^^^^^^^^^^^^^^
unused import: `EncodedChallenge`: halo2_backend/src/plonk/evaluation.rs#L12
warning: unused import: `EncodedChallenge` --> halo2_backend/src/plonk/evaluation.rs:12:18 | 12 | transcript::{EncodedChallenge, TranscriptWrite}, | ^^^^^^^^^^^^^^^^
unused imports: `MulAssign`, `Mul`, `collections::BTreeMap`, `iter`: halo2_backend/src/plonk/evaluation.rs#L29
warning: unused imports: `MulAssign`, `Mul`, `collections::BTreeMap`, `iter` --> halo2_backend/src/plonk/evaluation.rs:29:5 | 29 | collections::BTreeMap, | ^^^^^^^^^^^^^^^^^^^^^ 30 | iter, | ^^^^ 31 | ops::{Index, Mul, MulAssign}, | ^^^ ^^^^^^^^^
unused import: `std::time::Instant`: halo2_backend/src/plonk/evaluation.rs#L27
warning: unused import: `std::time::Instant` --> halo2_backend/src/plonk/evaluation.rs:27:5 | 27 | use std::time::Instant; | ^^^^^^^^^^^^^^^^^^
unused import: `std::slice`: halo2_backend/src/plonk/evaluation.rs#L26
warning: unused import: `std::slice` --> halo2_backend/src/plonk/evaluation.rs:26:5 | 26 | use std::slice; | ^^^^^^^^^^
unused import: `std::num::ParseIntError`: halo2_backend/src/plonk/evaluation.rs#L25
warning: unused import: `std::num::ParseIntError` --> halo2_backend/src/plonk/evaluation.rs:25:5 | 25 | use std::num::ParseIntError; | ^^^^^^^^^^^^^^^^^^^^^^^
unused import: `std::convert::TryInto`: halo2_backend/src/plonk/evaluation.rs#L24
warning: unused import: `std::convert::TryInto` --> halo2_backend/src/plonk/evaluation.rs:24:5 | 24 | use std::convert::TryInto; | ^^^^^^^^^^^^^^^^^^^^^
unused import: `std::any::TypeId`: halo2_backend/src/plonk/evaluation.rs#L23
warning: unused import: `std::any::TypeId` --> halo2_backend/src/plonk/evaluation.rs:23:5 | 23 | use std::any::TypeId; | ^^^^^^^^^^^^^^^^
unused imports: `BatchInvert`, `Curve`: halo2_backend/src/plonk/evaluation.rs#L16
warning: unused imports: `BatchInvert`, `Curve` --> halo2_backend/src/plonk/evaluation.rs:16:10 | 16 | ff::{BatchInvert, Field, PrimeField, WithSmallOrderMulGroup}, | ^^^^^^^^^^^ 17 | Curve, | ^^^^^
unused import: `group::prime::PrimeCurve`: halo2_backend/src/plonk/evaluation.rs#L14
warning: unused import: `group::prime::PrimeCurve` --> halo2_backend/src/plonk/evaluation.rs:14:5 | 14 | use group::prime::PrimeCurve; | ^^^^^^^^^^^^^^^^^^^^^^^^
unused imports: `EvaluationDomain`, `ProverQuery`, `TranscriptWrite`, `eval_polynomial`: halo2_backend/src/plonk/evaluation.rs#L7
warning: unused imports: `EvaluationDomain`, `ProverQuery`, `TranscriptWrite`, `eval_polynomial` --> halo2_backend/src/plonk/evaluation.rs:7:18 | 7 | arithmetic::{eval_polynomial, parallelize, CurveAffine}, | ^^^^^^^^^^^^^^^ 8 | poly::{ 9 | commitment::Params, Coeff, EvaluationDomain, ExtendedLagrangeCoeff, LagrangeCoeff, | ^^^^^^^^^^^^^^^^ 10 | Polynomial, ProverQuery, | ^^^^^^^^^^^ 11 | }, 12 | transcript::{EncodedChallenge, TranscriptWrite}, | ^^^^^^^^^^^^^^^
unused import: `crate::plonk::permutation::Argument`: halo2_backend/src/plonk/evaluation.rs#L3
warning: unused import: `crate::plonk::permutation::Argument` --> halo2_backend/src/plonk/evaluation.rs:3:5 | 3 | use crate::plonk::permutation::Argument; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `crate::plonk::lookup::prover::Committed`: halo2_backend/src/plonk/evaluation.rs#L2
warning: unused import: `crate::plonk::lookup::prover::Committed` --> halo2_backend/src/plonk/evaluation.rs:2:5 | 2 | use crate::plonk::lookup::prover::Committed; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
Clippy (beta)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/