Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting PhET-iO ready for review for screens 1-3 #63

Closed
AgustinVallejo opened this issue Nov 22, 2024 · 5 comments
Closed

Getting PhET-iO ready for review for screens 1-3 #63

AgustinVallejo opened this issue Nov 22, 2024 · 5 comments
Assignees

Comments

@AgustinVallejo
Copy link
Contributor

No description provided.

jbphet added a commit that referenced this issue Nov 26, 2024
AgustinVallejo added a commit that referenced this issue Dec 4, 2024
@jbphet
Copy link
Collaborator

jbphet commented Dec 14, 2024

@AgustinVallejo and I have taken a first shot at this, so screens 1 through 3 are ready for an initial review. I have to admit, I don't feel like I'm very good at deciding what the tree should look like, what should be featured, and where documentation is needed. I suspect this will take several reviews to get it into reasonable shape.

@arouinfar - Please review and let us know what needs to be changed. If it would be more efficient to do this together and potentially make some changes in real time, feel free to set up a meeting.

The dev version phet-io index can be found at https://phet-dev.colorado.edu/html/quantum-measurement/1.0.0-dev.10/phet-io/.

@AgustinVallejo
Copy link
Contributor Author

AgustinVallejo commented Dec 16, 2024

After today's meeting with Amy we talked about these improvements:

COINS

  • Identical Coins: Include title in the component.
  • CoinBias/StateToPrepare: Ensure the title doesn't show when both probability sliders have been hid.

PHOTONS

  • polarizationAngleControl: Add some margin to the panel
  • Ensure polarization indicator cannot escape (reinforce security measures and double the guards).
  • photonTestingArea: Totally uninstrument visibility properties:
    • Exclude visibility of classical/quantum radio buttons.
    • Exclude visibility of the laser button and slider.
  • Uninstrument AveragePolarization title.
    Uninstrument individual classical/quantum components. (Based on discussion in RadioButtonGroup PhET-iO API revision sun#920, this is not going to be supported.)
  • Link detector nodes and corresponding model elements.

SPIN

  • Ensure visibility of button and slider on the laser and uninstrument other visibilities.
  • BlochSphere: Don’t hide the sphere itself, only the entire node.
  • Manage visibility of measurementDevices as a whole.
  • Instrument histograms and include %% data somewhere.

@AgustinVallejo
Copy link
Contributor Author

Closing as the main things have been done. More PhET-iO discussion in #71

@phet-dev
Copy link
Contributor

Reopening because there is a TODO marked for this issue.

@jbphet
Copy link
Collaborator

jbphet commented Jan 14, 2025

There have been some refinements made to this and an issue is set up for review, see #79. Closing this one.

@jbphet jbphet closed this as completed Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants