Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review phet-io for screens 1-3, round 2 #71

Closed
jbphet opened this issue Dec 20, 2024 · 1 comment
Closed

Review phet-io for screens 1-3, round 2 #71

jbphet opened this issue Dec 20, 2024 · 1 comment

Comments

@jbphet
Copy link
Collaborator

jbphet commented Dec 20, 2024

In #63 the dev team submitted a version of the sim with an initial cut of the phet-io tree. We reviewed it with @arouinfar and have now folded in her feedback. The dev version at https://phet-dev.colorado.edu/html/quantum-measurement/1.0.0-dev.12/phet-io/ is the result, and it is ready for another round of review.

@arouinfar - please go through this when you have a chance and let us know where it stands.

@jbphet
Copy link
Collaborator Author

jbphet commented Jan 14, 2025

I started doing some phet-io review of the first screen on my own and found a few concerns, so I set up a quick review meeting for today (1/13/2025). This generated a list of changes, so I'll fold those in and set up a new dev version and GitHub issue. I'm going to close this one to avoid confusion.

@jbphet jbphet closed this as completed Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants