add ability to hide histogram via phet-io, see #63

phetsims · Jan 14, 2025 · 4cc1acb · 4cc1acb
1 parent 0be4a52
commit 4cc1acb
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/js/coins/view/CoinExperimentMeasurementArea.ts b/js/coins/view/CoinExperimentMeasurementArea.ts
@@ -46,7 +46,7 @@ export default class CoinExperimentMeasurementArea extends VBox {
   public constructor( sceneModel: CoinsExperimentSceneModel, tandem: Tandem ) {
 
     const textColorProperty = sceneModel.systemType === 'quantum' ?
-                      QuantumMeasurementColors.quantumSceneTextColorProperty : QuantumMeasurementColors.classicalSceneTextColorProperty;
+                              QuantumMeasurementColors.quantumSceneTextColorProperty : QuantumMeasurementColors.classicalSceneTextColorProperty;
     const singleCoinInTestBoxProperty = new BooleanProperty( false );
     const coinSetInTestBoxProperty = new BooleanProperty( false );
 
@@ -100,9 +100,13 @@ export default class CoinExperimentMeasurementArea extends VBox {
       sceneModel.coinSet.measuredDataChangedEmitter,
       { tandem: tandem.createTandem( 'multipleCoinTestBox' ) }
     );
+    const multiCoinExperimentHistogramTandem = tandem.createTandem( 'multiCoinExperimentHistogram' );
     const multiCoinExperimentHistogram = new CoinMeasurementHistogram( sceneModel.coinSet, sceneModel.systemType, {
-      visibleProperty: DerivedProperty.not( sceneModel.preparingExperimentProperty ),
-      tandem: tandem.createTandem( 'multiCoinExperimentHistogram' ),
+      visibleProperty: new GatedVisibleProperty(
+        DerivedProperty.not( sceneModel.preparingExperimentProperty ),
+        multiCoinExperimentHistogramTandem
+      ),
+      tandem: multiCoinExperimentHistogramTandem,
       leftFillColorProperty: sceneModel.systemType === 'classical' ? QuantumMeasurementColors.headsColorProperty : QuantumMeasurementColors.upColorProperty,
       rightFillColorProperty: sceneModel.systemType === 'classical' ? QuantumMeasurementColors.tailsColorProperty : QuantumMeasurementColors.downColorProperty
     } );

diff --git a/js/coins/view/CoinsExperimentSceneView.ts b/js/coins/view/CoinsExperimentSceneView.ts
@@ -121,6 +121,12 @@ class CoinsExperimentSceneView extends Node {
       this.updateActivityAreaPositions();
     } );
 
+    // Because phet-io actions can cause the size of the measurement area to change, we need to update the positions of
+    // the activity areas when the bounds of the measurement area change.
+    this.measurementArea.boundsProperty.link( () => {
+      this.updateActivityAreaPositions();
+    } );
+
     // Set the initial position that will be used when adding the coins that move (animate) between the preparation and
     // measurement areas.
     this.travelingCoinsOrigin = this.globalToLocalPoint( this.preparationArea.getIndicatorCoinGlobalCenter() );