Implementing live changes for phetio, see #63

phetsims · Dec 17, 2024 · f0be317 · f0be317
1 parent 93ff689
commit f0be317
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/js/photons/view/PhotonsExperimentSceneView.ts b/js/photons/view/PhotonsExperimentSceneView.ts
@@ -57,7 +57,7 @@ export default class PhotonsExperimentSceneView extends Node {
 
       // center position empirically determined to match design doc
       center: new Vector2( 420, 225 ),
-
+      phetioVisiblePropertyInstrumented: false,
       tandem: providedOptions.tandem.createTandem( 'photonTestingArea' )
     } );
 

diff --git a/js/spin/view/SpinStatePreparationArea.ts b/js/spin/view/SpinStatePreparationArea.ts
@@ -9,6 +9,7 @@
 
 import DerivedProperty from '../../../../axon/js/DerivedProperty.js';
 import DerivedStringProperty from '../../../../axon/js/DerivedStringProperty.js';
+import { GatedVisibleProperty } from '../../../../axon/js/GatedBooleanProperty.js';
 import Bounds2 from '../../../../dot/js/Bounds2.js';
 import Utils from '../../../../dot/js/Utils.js';
 import Vector2 from '../../../../dot/js/Vector2.js';
@@ -65,14 +66,15 @@ export default class SpinStatePreparationArea extends VBox {
       };
     };
 
+    const spinStateRadioButtonGroupTandem = tandem.createTandem( 'spinStateRadioButtonGroup' );
     const spinStateRadioButtonGroup = new RectangularRadioButtonGroup(
       model.particleSourceModel.spinStateProperty,
       SpinDirection.enumeration.values.map( quantity => createRadioButtonGroupItem( quantity ) ),
       {
         spacing: 10,
         center: new Vector2( 100, 100 ),
-        tandem: tandem.createTandem( 'spinStateRadioButtonGroup' ),
-        visibleProperty: new DerivedProperty( [ model.currentExperimentProperty ], currentExperiment => currentExperiment !== SpinExperiment.CUSTOM ),
+        tandem: spinStateRadioButtonGroupTandem,
+        visibleProperty: new GatedVisibleProperty( new DerivedProperty( [ model.currentExperimentProperty ], currentExperiment => currentExperiment !== SpinExperiment.CUSTOM ), spinStateRadioButtonGroupTandem ),
         radioButtonOptions: {
           minWidth: 200,
           baseColor: QuantumMeasurementColors.controlPanelFillColorProperty