Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSASINFRA-3483: Prepare for openstack-cinder Hypershift integration #510

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

OSASINFRA-3483: Prepare for openstack-cinder Hypershift integration #510

wants to merge 2 commits into from
+524 −15

Conversation

stephenfin
Copy link
Contributor

Rejig our asset generation and controller to prepare for a Hypershift-ful future.

This is closely modeled on #318 but without the Hypershift-specific assets since those are not ready yet.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 27, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 27, 2024 •
edited by openshift-ci bot
Loading

@stephenfin: This pull request references OSASINFRA-3483 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

Rejig our asset generation and controller to prepare for a Hypershift-ful future.

This is closely modeled on #318 but without the Hypershift-specific assets since those are not ready yet.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stephenfin
Copy link
Contributor Author

/cc @MaysaMacedo
/cc @mandre

@stephenfin
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 27, 2024 •
edited by openshift-ci bot
Loading

@stephenfin: This pull request references OSASINFRA-3483 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stephenfin
Copy link
Contributor Author

/test e2e-openstack-parallel

@stephenfin stephenfin mentioned this pull request Sep 30, 2024
Merged
@MaysaMacedo MaysaMacedo mentioned this pull request Oct 1, 2024
Closed
@stephenfin stephenfin mentioned this pull request Oct 1, 2024
Open
@stephenfin
Copy link
Contributor Author

/test e2e-openstack-parallel

1 similar comment
@stephenfin
Copy link
Contributor Author

/test e2e-openstack-parallel

@stephenfin stephenfin mentioned this pull request Oct 17, 2024
Draft
@stephenfin
Copy link
Contributor Author

/test e2e-openstack-parallel
/test e2e-gcp-csi

@stephenfin
Copy link
Contributor Author

/test e2e-ibmcloud-csi

@MaysaMacedo
Copy link
Contributor

/lgtm

@MaysaMacedo
Copy link
Contributor

/test e2e-openstack
/test e2e-vsphere-csi

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2024
@MaysaMacedo
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2024
@gnufied
Copy link
Member

gnufied commented Oct 30, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2024
@gnufied
Copy link
Member

gnufied commented Oct 30, 2024

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Oct 30, 2024
@stephenfin
Copy link
Contributor Author

Rebased due to conflicts introduced by #524

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2024
@stephenfin
openstack-cinder: Integrate kustomize
2ac59d8 
This currently does zilch, but it establishes the framework we can use
as we work on Hypershift integration.

Signed-off-by: Stephen Finucane <[email protected]>
@MaysaMacedo
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2024
@stephenfin
Copy link
Contributor Author

/test e2e-openstack-csi

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

@stephenfin: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-aws-csi
  • /test e2e-aws-ovn-upgrade
  • /test e2e-azure-csi
  • /test e2e-azure-file-csi
  • /test e2e-gcp-csi
  • /test e2e-vsphere-csi
  • /test hypershift-aws-e2e-external
  • /test images
  • /test unit
  • /test verify
  • /test verify-deps
  • /test verify-kustomize-assets

The following commands are available to trigger optional jobs:

  • /test e2e-aws-ovn
  • /test e2e-azure-manual-oidc
  • /test e2e-azure-ovn
  • /test e2e-gcp-manual-oidc
  • /test e2e-gcp-ovn
  • /test e2e-ibmcloud-csi
  • /test e2e-openstack
  • /test e2e-openstack-parallel
  • /test e2e-ovn-vsphere
  • /test okd-scos-images
  • /test security

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-cluster-storage-operator-master-e2e-aws-csi
  • pull-ci-openshift-cluster-storage-operator-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-cluster-storage-operator-master-e2e-azure-csi
  • pull-ci-openshift-cluster-storage-operator-master-e2e-azure-file-csi
  • pull-ci-openshift-cluster-storage-operator-master-e2e-gcp-csi
  • pull-ci-openshift-cluster-storage-operator-master-e2e-gcp-manual-oidc
  • pull-ci-openshift-cluster-storage-operator-master-e2e-ibmcloud-csi
  • pull-ci-openshift-cluster-storage-operator-master-e2e-openstack
  • pull-ci-openshift-cluster-storage-operator-master-e2e-openstack-parallel
  • pull-ci-openshift-cluster-storage-operator-master-e2e-vsphere-csi
  • pull-ci-openshift-cluster-storage-operator-master-hypershift-aws-e2e-external
  • pull-ci-openshift-cluster-storage-operator-master-images
  • pull-ci-openshift-cluster-storage-operator-master-security
  • pull-ci-openshift-cluster-storage-operator-master-unit
  • pull-ci-openshift-cluster-storage-operator-master-verify
  • pull-ci-openshift-cluster-storage-operator-master-verify-deps
  • pull-ci-openshift-cluster-storage-operator-master-verify-kustomize-assets

In response to this:

/test e2e-openstack-csi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@EmilienM
Copy link
Member

EmilienM commented Nov 5, 2024

/test e2e-openstack-cinder-csi

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 5, 2024

@stephenfin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-file-csi 2ac59d8 link true /test e2e-azure-file-csi
ci/prow/e2e-azure-csi 2ac59d8 link true /test e2e-azure-csi
ci/prow/e2e-openstack-cinder-csi 2ac59d8 link false /test e2e-openstack-cinder-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rlobillo
Copy link

rlobillo commented Nov 6, 2024

/qe-approved

According to the results of e2e-openstack-cinder-csi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dobsonj dobsonj Awaiting requested review from dobsonj

@gnufied gnufied Awaiting requested review from gnufied

@mandre mandre Awaiting requested review from mandre

@MaysaMacedo MaysaMacedo Awaiting requested review from MaysaMacedo

Assignees

@gnufied gnufied

@MaysaMacedo MaysaMacedo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@stephenfin @openshift-ci-robot @MaysaMacedo @gnufied @EmilienM @rlobillo @openshift-merge-robot