NO-JIRA: Always recreate manifests

[stephenfin]

• hack: Address shellcheck issues
• hack: Make HyperShift asset generation optional
• hack: Always recreate manifests

[openshift-ci-robot]

@stephenfin: This pull request explicitly references no jira issue.

In response to this:

• hack: Address shellcheck issues
• hack: Make HyperShift asset generation optional
• hack: Always recreate manifests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[stephenfin]

Pulling this out of #510 to see if I can isolate why the CI is unhappy with this.

[jsafrane]

@stephenfin please run make update to fix verify-kustomize-assets.

[stephenfin]

@stephenfin please run make update to fix verify-kustomize-assets.

That's the issue: I did, and things just work locally yet the job is not happy:

❯ git clean -xfd
Removing _output/
❯ make update && echo "done" || echo "failed"
Running `gofmt -s -l -w` on 40 file(s).
Using existing yq from "_output/tools/bin/yq-2.4.0"
Using existing yaml-patch from "_output/tools/bin/yaml-patch-v0.0.11"
( echo '# *** AUTOMATICALLY GENERATED FILE - DO NOT EDIT ***'; _output/tools/bin/yaml-patch-v0.0.11 -o './profile-patches/hypershift/06_operator_cr.yaml-patch' < '/home/stephenfin/Development/shiftstack/cluster-storage-operator/manifests/06_operator_cr.yaml' ) > '/home/stephenfin/Development/shiftstack/cluster-storage-operator/manifests/06_operator_cr-hypershift.yaml'
( echo '# *** AUTOMATICALLY GENERATED FILE - DO NOT EDIT ***'; _output/tools/bin/yaml-patch-v0.0.11 -o './profile-patches/hypershift/07_service_account.yaml-patch' < '/home/stephenfin/Development/shiftstack/cluster-storage-operator/manifests/07_service_account.yaml' ) > '/home/stephenfin/Development/shiftstack/cluster-storage-operator/manifests/07_service_account-hypershift.yaml'
( echo '# *** AUTOMATICALLY GENERATED FILE - DO NOT EDIT ***'; _output/tools/bin/yaml-patch-v0.0.11 -o './profile-patches/hypershift/08_operator_rbac.yaml-patch' < '/home/stephenfin/Development/shiftstack/cluster-storage-operator/manifests/08_operator_rbac.yaml' ) > '/home/stephenfin/Development/shiftstack/cluster-storage-operator/manifests/08_operator_rbac-hypershift.yaml'
( echo '# *** AUTOMATICALLY GENERATED FILE - DO NOT EDIT ***'; _output/tools/bin/yaml-patch-v0.0.11 -o './profile-patches/hypershift/10_deployment.yaml-patch' < '/home/stephenfin/Development/shiftstack/cluster-storage-operator/manifests/10_deployment.yaml' ) > '/home/stephenfin/Development/shiftstack/cluster-storage-operator/manifests/10_deployment-hypershift.yaml'
( echo '# *** AUTOMATICALLY GENERATED FILE - DO NOT EDIT ***'; _output/tools/bin/yaml-patch-v0.0.11 -o './profile-patches/hypershift/11_cluster_operator.yaml-patch' < '/home/stephenfin/Development/shiftstack/cluster-storage-operator/manifests/11_cluster_operator.yaml' ) > '/home/stephenfin/Development/shiftstack/cluster-storage-operator/manifests/11_cluster_operator-hypershift.yaml'
( echo '# *** AUTOMATICALLY GENERATED FILE - DO NOT EDIT ***'; _output/tools/bin/yaml-patch-v0.0.11 -o './profile-patches/ibm-cloud-managed/10_deployment.yaml-patch' < '/home/stephenfin/Development/shiftstack/cluster-storage-operator/manifests/10_deployment.yaml' ) > '/home/stephenfin/Development/shiftstack/cluster-storage-operator/manifests/10_deployment-ibm-cloud-managed.yaml'
./hack/generate-manifests.sh
done

Am I missing something obvious or is the job broken?

[jsafrane]

The job is broken for a long time. I can see it reported the same oc: command not found, but ended up green from some reason.

I'm fixing it in openshift/release#57308

[stephenfin]

The job is broken for a long time. I can see it reported the same oc: command not found, but ended up green from some reason.

I'm fixing it in openshift/release#57308

Okay, cool. I had an alternative suggestion locally, namely using kustomize build instead of oc kustomize, that I've just pushed. wdyt about that approach instead?

Scrub that. That changes the update makefile target which isn't the thing that's failing.

[jsafrane]

/retest-required

[jsafrane]

/test verify-kustomize-assets

[openshift-ci]

@stephenfin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-manual-oidc	8fafb84	link	false	/test e2e-gcp-manual-oidc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jsafrane]

/retest-required
/lgtm
/approve
/label px-approved
/label docs-approved
/label qe-approved
Not user facing, no generated yaml file has changed.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment