OSASINFRA-3632: Add Hypershift support to openstack-cinder #525
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@stephenfin: This pull request references OSASINFRA-3483 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stephenfin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc @EmilienM |
stephenfin
changed the title
|
@stephenfin: This pull request references OSASINFRA-3632 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@stephenfin: This pull request references OSASINFRA-3632 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@stephenfin: This pull request references OSASINFRA-3632 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-vsphere-csi |
stephenfin
force-pushed
the
add-cinder-csi-part-2
branch
from
77d74f7
to
ecdc768
Compare
stephenfin
force-pushed
the
add-cinder-csi-part-2
branch
2 times, most recently
from
2e832b0
to
9d919b0
Compare
...t/generated/rbac.authorization.k8s.io_v1_role_openstack-cinder-csi-driver-operator-role.yaml
Show resolved
Hide resolved
| items: | ||
| - key: clouds.yaml | ||
| path: clouds.yaml | ||
| secretName: openstack-cloud-credentials |
There was a problem hiding this comment.
A CredentialsRequest needs to be added to the hosted cluster, otherwise no openstack-cloud-credentials will exist
There was a problem hiding this comment.
Actually, this seems to be addressed by this other PR https://github.com/openshift/hypershift/pull/4936/files#diff-0de67b02a8275f7a8227b3af5101786e70e5c651b852a87f6160f6563a9071d6R281-R284
openshift-merge-robot
added
the
needs-rebase
stephenfin
force-pushed
the
add-cinder-csi-part-2
branch
from
9d919b0
to
e6a2fff
Compare
openshift-merge-robot
removed
the
needs-rebase
stephenfin
force-pushed
the
add-cinder-csi-part-2
branch
3 times, most recently
from
cbd0473
to
619b36c
Compare
Signed-off-by: Stephen Finucane <[email protected]>
This currently does zilch, but it establishes the framework we can use as we work on Hypershift integration. Signed-off-by: Stephen Finucane <[email protected]>
This (undocumented) annotation is used to indicate that the asset should not be included in the mangement cluster. Why things are done this way rather than simply duplicating the file in 'standalone' and 'hypershift/guest' is an interesting question, but I do not get paid enough to ask such questions 😉 Signed-off-by: Stephen Finucane <[email protected]>
We do not want this to run in the management cluster in a HCP deployment. This has no effect on the generated assets for the standlone cluster. Signed-off-by: Stephen Finucane <[email protected]>
We historically restricted the CSI Driver operator deployments to master nodes. This obviously won't work for HCP deployments where the hosted control plane runs on worker nodes. Add patches to only add the relevant 'nodeSelector' and 'tolerations' attributes in a standalone deployment scenario. Signed-off-by: Stephen Finucane <[email protected]>
…ole to role These permissions can be namespaced. They don't need to be cluster-wide. Signed-off-by: Stephen Finucane <[email protected]>
Signed-off-by: Stephen Finucane <[email protected]>
These do not appear to be necessary and the conflict with the roles granted by HCP's control-plane-operator [1]. [1] https://github.com/openshift/hypershift/blob/main/control-plane-operator/controllers/hostedcontrolplane/storage/assets/role.yaml Signed-off-by: Stephen Finucane <[email protected]>
This is mostly inspired by azure-disk changes. Plenty of comments are scattered through the code explaining what we're doing and why. Go read those instead of this. Go on, go! Signed-off-by: Stephen Finucane <[email protected]>
Generated with 'make update'. Nothing much to see here. Signed-off-by: Stephen Finucane <[email protected]>
Signed-off-by: Stephen Finucane <[email protected]>
The final step in our journey: we start using the assets generated in earlier commits and formally add support for Cinder on Hypershift. Signed-off-by: Stephen Finucane <[email protected]>
stephenfin
force-pushed
the
add-cinder-csi-part-2
branch
from
619b36c
to
1d5c2a4
Compare
openshift-ci
bot
added
the
do-not-merge/work-in-progress
This is a continuation of #510, which set up the laid the groundwork for Hypershift integration by rejigging asset generation.
In this PR, we do the actual work of integrating Hypershift support. This is closely modeled on the
azure-diskexample, which should be no surprise given how similar the various CSI Driver Operators are.Related changes