Added jackson dependency to server

[ryanbogan]

Signed-off-by: Ryan Bogan [email protected]

Description

In order for extensions to be read, the jackson dependency must be included in the server build.gradle file. This PR adds the license, notice, and SHA files necessary to accomplish this.
Note: Although the jackson files for plugins and modules are being deleted with this PR, they still have access under server and no functionality will be changed for them.

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/7294/
• CommitID: 5de4cb1
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/7295/
• CommitID: 181da45
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/7348/
• CommitID: a814b11
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[reta]

@ryanbogan this is interesting, it seems like :libs:opensearch-x-content brings these dependencies to the server already?

+--- project :libs:opensearch-x-content                  
|    +--- project :libs:opensearch-core                     
|    +--- org.yaml:snakeyaml:1.32                               
|    +--- com.fasterxml.jackson.core:jackson-core:2.14.1    
|    +--- com.fasterxml.jackson.dataformat:jackson-dataformat-smile:2.14.1
|    +--- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.14.1
|    \--- com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:2.14.1

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/7356/
• CommitID: 0f6a154
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[ryanbogan]

@ryanbogan this is interesting, it seems like :libs:opensearch-x-content brings these dependencies to the server already?

+--- project :libs:opensearch-x-content                  
|    +--- project :libs:opensearch-core                     
|    +--- org.yaml:snakeyaml:1.32                               
|    +--- com.fasterxml.jackson.core:jackson-core:2.14.1    
|    +--- com.fasterxml.jackson.dataformat:jackson-dataformat-smile:2.14.1
|    +--- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.14.1
|    \--- com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:2.14.1

Without the dependency in the server build.gradle file, import errors are thrown on compilation for every object in the jackson library.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/7357/
• CommitID: 0f6a154
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[dblock]

Assuming you can get this to 🟢 I don't see any reasons not to merge this.

[ryanbogan]

@dblock The problem is that I'm not sure why it's failing when the git diff is identical to changes that are passing here: #5347. Do you think it's possible that it would fail if no files are using the jackson dependency in server yet?

[dblock]

Can you reproduce the failure locally?

> Task :plugins:discovery-ec2:qa:amazon-ec2:yamlRestTestContainerCredentials FAILED

=== Standard output of node `node{:plugins:discovery-ec2:qa:amazon-ec2:yamlRestTestContainerCredentials-0}` ===

»    ↓ errors and warnings from /var/jenkins/workspace/gradle-check/search/plugins/discovery-ec2/qa/amazon-ec2/build/testclusters/yamlRestTestContainerCredentials-0/logs/opensearch.stdout.log ↓
» ERROR][o.o.b.OpenSearchUncaughtExceptionHandler] [yamlRestTestContainerCredentials-0] fatal error in thread [main], exiting
»  java.lang.ExceptionInInitializerError: null
»  	at com.amazonaws.util.VersionInfoUtils.userAgent(VersionInfoUtils.java:142) ~[?:?]
»  	at com.amazonaws.util.VersionInfoUtils.initializeUserAgent(VersionInfoUtils.java:137) ~[?:?]
»  	at com.amazonaws.util.VersionInfoUtils.getUserAgent(VersionInfoUtils.java:100) ~[?:?]
»  	at com.amazonaws.ClientConfiguration.<clinit>(ClientConfiguration.java:80) ~[?:?]

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/7678/
• CommitID: 0f6a154
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[ryanbogan]

Can you reproduce the failure locally?

Yes I can reproduce it locally.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/7687/
• CommitID: 55107cf
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/7759/
• CommitID: 69f7276

[codecov-commenter]

Codecov Report

Merging #5366 (69f7276) into main (5500114) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #5366      +/-   ##
============================================
- Coverage     71.02%   71.01%   -0.02%     
- Complexity    58192    58211      +19     
============================================
  Files          4711     4711              
  Lines        277574   277574              
  Branches      40182    40182              
============================================
- Hits         197155   197127      -28     
- Misses        64294    64332      +38     
+ Partials      16125    16115      -10     

Impacted Files	Coverage Δ
...adonly/AddIndexBlockClusterStateUpdateRequest.java	0.00% <0.00%> (-75.00%)	⬇️
...adcast/BroadcastShardOperationFailedException.java	33.33% <0.00%> (-66.67%)	⬇️
...readonly/TransportVerifyShardIndexBlockAction.java	9.75% <0.00%> (-58.54%)	⬇️
...n/admin/indices/readonly/AddIndexBlockRequest.java	17.85% <0.00%> (-53.58%)	⬇️
...ch/transport/ReceiveTimeoutTransportException.java	50.00% <0.00%> (-50.00%)	⬇️
...opensearch/persistent/PersistentTasksExecutor.java	22.22% <0.00%> (-44.45%)	⬇️
...indices/readonly/TransportAddIndexBlockAction.java	20.68% <0.00%> (-41.38%)	⬇️
.../admin/cluster/reroute/ClusterRerouteResponse.java	60.00% <0.00%> (-40.00%)	⬇️
...luster/routing/allocation/RoutingExplanations.java	62.06% <0.00%> (-37.94%)	⬇️
.../admin/indices/readonly/AddIndexBlockResponse.java	0.00% <0.00%> (-37.50%)	⬇️
... and 497 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[owaiskazi19]

@dblock @saratvemulapalli @dbwiddis since we are removing jackson library from the native plugins and adding it in server. Need to add the above permissions. Looking for some advice if providing accessDeclaredMembers will bring any security concerns since we are enabling it for the server module? If not, then I guess we are good to go.

[ryanbogan]

^ We have these lines in feature/extensions as well so if there are security concerns we should fix them there too.

[dblock]

Let's open an issue. I don't know what the impact of this change is.

[owaiskazi19]

@ryanbogan can you take care of it?

[ryanbogan]

Already open: #5504

[dblock]

Let's open an issue. I don't know what the impact of this change is.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-5366-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c6663fd7f4e74b3ed1b6ad70e758b3e6bd21f816
# Push it to GitHub
git push --set-upstream origin backport/backport-5366-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-5366-to-2.x.

[dblock]

@ryanbogan will need a manual backport to come to 2.x